Commit c537338c authored Apr 01, 2020 by Kees Cook Committed by Linus Torvalds Apr 02, 2020

fs_parse: remove pr_notice() about each validation



This notice fills my boot logs with scary-looking asterisks but doesn't
really tell me anything.  Let's just remove it; validation errors are
already reported separately, so this is just a redundant list of
filesystems.

$ dmesg | grep VALIDATE
[    0.306256] *** VALIDATE tmpfs ***
[    0.307422] *** VALIDATE proc ***
[    0.308355] *** VALIDATE cgroup ***
[    0.308741] *** VALIDATE cgroup2 ***
[    0.813256] *** VALIDATE bpf ***
[    0.815272] *** VALIDATE ramfs ***
[    0.815665] *** VALIDATE hugetlbfs ***
[    0.876970] *** VALIDATE nfs ***
[    0.877383] *** VALIDATE nfs4 ***

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Seth Arnold <seth.arnold@canonical.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Link: http://lkml.kernel.org/r/202003061617.A8835CAAF@keescook


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4ceb229f

fs/fs_parser.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
		const struct fs_parameter_spec param, p2;
		bool good = true;

		pr_notice("* VALIDATE %s *\n", name);

		for (param = desc; param->name; param++) {
		/* Check for duplicate parameter names */
		for (p2 = desc; p2 < param; p2++) {

Admin message