Commit c5272a28 authored May 01, 2015 by Doug Anderson Committed by Linus Walleij May 06, 2015

pinctrl: Don't just pretend to protect pinctrl_maps, do it for real



Way back, when the world was a simpler place and there was no war, no
evil, and no kernel bugs, there was just a single pinctrl lock.  That
was how the world was when (57291ce2 pinctrl: core device tree mapping
table parsing support) was written.  In that case, there were
instances where the pinctrl mutex was already held when
pinctrl_register_map() was called, hence a "locked" parameter was
passed to the function to indicate that the mutex was already locked
(so we shouldn't lock it again).

A few years ago in (42fed7ba pinctrl: move subsystem mutex to
pinctrl_dev struct), we switched to a separate pinctrl_maps_mutex.
...but (oops) we forgot to re-think about the whole "locked" parameter
for pinctrl_register_map().  Basically the "locked" parameter appears
to still refer to whether the bigger pinctrl_dev mutex is locked, but
we're using it to skip locks of our (now separate) pinctrl_maps_mutex.

That's kind of a bad thing(TM).  Probably nobody noticed because most
of the calls to pinctrl_register_map happen at boot time and we've got
synchronous device probing.  ...and even cases where we're
asynchronous don't end up actually hitting the race too often.  ...but
after banging my head against the wall for a bug that reproduced 1 out
of 1000 reboots and lots of looking through kgdb, I finally noticed
this.

Anyway, we can now safely remove the "locked" parameter and go back to
a war-free, evil-free, and kernel-bug-free world.

Fixes: 42fed7ba ("pinctrl: move subsystem mutex to pinctrl_dev struct")
Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 74d77e50

drivers/pinctrl/core.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -1110,7 +1110,7 @@ void devm_pinctrl_put(struct pinctrl *p)
		EXPORT_SYMBOL_GPL(devm_pinctrl_put);

		int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
		bool dup, bool locked)
		bool dup)
		{
		int i, ret;
		struct pinctrl_maps *maps_node;
		@@ -1178,10 +1178,8 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
		maps_node->maps = maps;
		}

		if (!locked)
		mutex_lock(&pinctrl_maps_mutex);
		list_add_tail(&maps_node->node, &pinctrl_maps);
		if (!locked)
		mutex_unlock(&pinctrl_maps_mutex);

		return 0;
		@@ -1197,7 +1195,7 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
		int pinctrl_register_mappings(struct pinctrl_map const *maps,
		unsigned num_maps)
		{
		return pinctrl_register_map(maps, num_maps, true, false);
		return pinctrl_register_map(maps, num_maps, true);
		}

		void pinctrl_unregister_map(struct pinctrl_map const *map)

drivers/pinctrl/core.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -183,7 +183,7 @@ static inline struct pin_desc pin_desc_get(struct pinctrl_dev pctldev,
		}

		int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
		bool dup, bool locked);
		bool dup);
		void pinctrl_unregister_map(struct pinctrl_map const *map);

		extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev);

drivers/pinctrl/devicetree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -92,7 +92,7 @@ static int dt_remember_or_free_map(struct pinctrl p, const char statename,
		dt_map->num_maps = num_maps;
		list_add_tail(&dt_map->node, &p->dt_maps);

		return pinctrl_register_map(map, num_maps, false, true);
		return pinctrl_register_map(map, num_maps, false);
		}

		struct pinctrl_dev of_pinctrl_get(struct device_node np)

Admin message