Unverified Commit c50519e6 authored by Jernej Skrabec's avatar Jernej Skrabec Committed by Maxime Ripard
Browse files

drm/sun4i: Add basic support for DE3 



Display Engine 3 is an upgrade of DE2 with new features like support for
10 bit color formats and support for AFBC.

Most of DE2 code works with DE3, except some small details.

Implement basic support for DE3. Support for 10 bit colort formats and
AFBC, among others missing features, will be added later.

Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/260238/
parent 97eb57fe

drivers/gpu/drm/sun4i/sun8i_csc.c

+83 −0
Original line number Diff line number Diff line
@@ -34,6 +34,41 @@ static const u32 yvu2rgb[] = { 
	0x000004A8, 0x00000000, 0x00000813, 0xFFFBAC4A,

};



/*

 * DE3 has a bit different CSC units. Factors are in two's complement format.

 * First three factors in a row are multiplication factors which have 17 bits

 * for fractional part. Fourth value in a row is comprised of two factors.

 * Upper 16 bits represents difference, which is subtracted from the input

 * value before multiplication and lower 16 bits represents constant, which

 * is addes at the end.

 *

 * x' = c00 * (x + d0) + c01 * (y + d1) + c02 * (z + d2) + const0

 * y' = c10 * (x + d0) + c11 * (y + d1) + c12 * (z + d2) + const1

 * z' = c20 * (x + d0) + c21 * (y + d1) + c22 * (z + d2) + const2

 *

 * Please note that above formula is true only for Blender CSC. Other DE3 CSC

 * units takes only positive value for difference. From what can be deducted

 * from BSP driver code, those units probably automatically assume that

 * difference has to be subtracted.

 *

 * Layout of factors in table:

 * c00 c01 c02 [d0 const0]

 * c10 c11 c12 [d1 const1]

 * c20 c21 c22 [d2 const2]

 */



static const u32 yuv2rgb_de3[] = {

	0x0002542a, 0x00000000, 0x0003312a, 0xffc00000,

	0x0002542a, 0xffff376b, 0xfffe5fc3, 0xfe000000,

	0x0002542a, 0x000408d3, 0x00000000, 0xfe000000,

};



static const u32 yvu2rgb_de3[] = {

	0x0002542a, 0x0003312a, 0x00000000, 0xffc00000,

	0x0002542a, 0xfffe5fc3, 0xffff376b, 0xfe000000,

	0x0002542a, 0x00000000, 0x000408d3, 0xfe000000,

};



static void sun8i_csc_set_coefficients(struct regmap *map, u32 base,

				       enum sun8i_csc_mode mode)

{
@@ -61,6 +96,28 @@ static void sun8i_csc_set_coefficients(struct regmap *map, u32 base, 
	}

}



static void sun8i_de3_ccsc_set_coefficients(struct regmap *map, int layer,

					    enum sun8i_csc_mode mode)

{

	const u32 *table;

	u32 base_reg;



	switch (mode) {

	case SUN8I_CSC_MODE_YUV2RGB:

		table = yuv2rgb_de3;

		break;

	case SUN8I_CSC_MODE_YVU2RGB:

		table = yvu2rgb_de3;

		break;

	default:

		DRM_WARN("Wrong CSC mode specified.\n");

		return;

	}



	base_reg = SUN50I_MIXER_BLEND_CSC_COEFF(DE3_BLD_BASE, layer, 0, 0);

	regmap_bulk_write(map, base_reg, table, 12);

}



static void sun8i_csc_enable(struct regmap *map, u32 base, bool enable)

{

	u32 val;
@@ -73,11 +130,32 @@ static void sun8i_csc_enable(struct regmap *map, u32 base, bool enable) 
	regmap_update_bits(map, SUN8I_CSC_CTRL(base), SUN8I_CSC_CTRL_EN, val);

}



static void sun8i_de3_ccsc_enable(struct regmap *map, int layer, bool enable)

{

	u32 val, mask;



	mask = SUN50I_MIXER_BLEND_CSC_CTL_EN(layer);



	if (enable)

		val = mask;

	else

		val = 0;



	regmap_update_bits(map, SUN50I_MIXER_BLEND_CSC_CTL(DE3_BLD_BASE),

			   mask, val);

}



void sun8i_csc_set_ccsc_coefficients(struct sun8i_mixer *mixer, int layer,

				     enum sun8i_csc_mode mode)

{

	u32 base;



	if (mixer->cfg->is_de3) {

		sun8i_de3_ccsc_set_coefficients(mixer->engine.regs,

						layer, mode);

		return;

	}



	base = ccsc_base[mixer->cfg->ccsc][layer];



	sun8i_csc_set_coefficients(mixer->engine.regs, base, mode);
@@ -87,6 +165,11 @@ void sun8i_csc_enable_ccsc(struct sun8i_mixer *mixer, int layer, bool enable) 
{

	u32 base;



	if (mixer->cfg->is_de3) {

		sun8i_de3_ccsc_enable(mixer->engine.regs, layer, enable);

		return;

	}



	base = ccsc_base[mixer->cfg->ccsc][layer];



	sun8i_csc_enable(mixer->engine.regs, base, enable);

drivers/gpu/drm/sun4i/sun8i_mixer.c

+27 −12
Original line number Diff line number Diff line
@@ -459,11 +459,25 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master, 


	base = sun8i_blender_base(mixer);



	/* Reset the registers */

	/* Reset registers and disable unused sub-engines */

	if (mixer->cfg->is_de3) {

		for (i = 0; i < DE3_MIXER_UNIT_SIZE; i += 4)

			regmap_write(mixer->engine.regs, i, 0);



		regmap_write(mixer->engine.regs, SUN50I_MIXER_FCE_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_PEAK_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_LCTI_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_BLS_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_FCC_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_DNS_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_DRC_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_FMT_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC0_EN, 0);

		regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC1_EN, 0);

	} else {

		for (i = 0; i < DE2_MIXER_UNIT_SIZE; i += 4)

			regmap_write(mixer->engine.regs, i, 0);



	/* Disable unused sub-engines */

		regmap_write(mixer->engine.regs, SUN8I_MIXER_FCE_EN, 0);

		regmap_write(mixer->engine.regs, SUN8I_MIXER_BWS_EN, 0);

		regmap_write(mixer->engine.regs, SUN8I_MIXER_LTI_EN, 0);
@@ -471,6 +485,7 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master, 
		regmap_write(mixer->engine.regs, SUN8I_MIXER_ASE_EN, 0);

		regmap_write(mixer->engine.regs, SUN8I_MIXER_FCC_EN, 0);

		regmap_write(mixer->engine.regs, SUN8I_MIXER_DCSC_EN, 0);

	}



	/* Enable the mixer */

	regmap_write(mixer->engine.regs, SUN8I_MIXER_GLOBAL_CTL,

drivers/gpu/drm/sun4i/sun8i_mixer.h

+32 −2
Original line number Diff line number Diff line
@@ -30,11 +30,16 @@ 
#define SUN8I_MIXER_GLOBAL_DBUFF_ENABLE		BIT(0)



#define DE2_MIXER_UNIT_SIZE			0x6000

#define DE3_MIXER_UNIT_SIZE			0x3000



#define DE2_BLD_BASE				0x1000

#define DE2_CH_BASE				0x2000

#define DE2_CH_SIZE				0x1000



#define DE3_BLD_BASE				0x0800

#define DE3_CH_BASE				0x1000

#define DE3_CH_SIZE				0x0800



#define SUN8I_MIXER_BLEND_PIPE_CTL(base)	((base) + 0)

#define SUN8I_MIXER_BLEND_ATTR_FCOLOR(base, x)	((base) + 0x4 + 0x10 * (x))

#define SUN8I_MIXER_BLEND_ATTR_INSIZE(base, x)	((base) + 0x8 + 0x10 * (x))
@@ -49,10 +54,16 @@ 
#define SUN8I_MIXER_BLEND_CK_MAX(base, x)	((base) + 0xc0 + 0x04 * (x))

#define SUN8I_MIXER_BLEND_CK_MIN(base, x)	((base) + 0xe0 + 0x04 * (x))

#define SUN8I_MIXER_BLEND_OUTCTL(base)		((base) + 0xfc)

#define SUN50I_MIXER_BLEND_CSC_CTL(base)	((base) + 0x100)

#define SUN50I_MIXER_BLEND_CSC_COEFF(base, layer, x, y) \

	((base) + 0x110 + (layer) * 0x30 +  (x) * 0x10 + 4 * (y))

#define SUN50I_MIXER_BLEND_CSC_CONST(base, layer, i) \

	((base) + 0x110 + (layer) * 0x30 +  (i) * 0x10 + 0x0c)



#define SUN8I_MIXER_BLEND_PIPE_CTL_EN_MSK	GENMASK(12, 8)

#define SUN8I_MIXER_BLEND_PIPE_CTL_EN(pipe)	BIT(8 + pipe)

#define SUN8I_MIXER_BLEND_PIPE_CTL_FC_EN(pipe)	BIT(pipe)



/* colors are always in AARRGGBB format */

#define SUN8I_MIXER_BLEND_COLOR_BLACK		0xff000000

/* The following numbers are some still unknown magic numbers */
@@ -63,6 +74,9 @@ 


#define SUN8I_MIXER_BLEND_OUTCTL_INTERLACED	BIT(1)



#define SUN50I_MIXER_BLEND_CSC_CTL_EN(ch)	BIT(ch)

#define SUN50I_MIXER_BLEND_CSC_CONST_VAL(d, c)	(((d) << 16) | ((c) & 0xffff))



#define SUN8I_MIXER_FBFMT_ARGB8888	0

#define SUN8I_MIXER_FBFMT_ABGR8888	1

#define SUN8I_MIXER_FBFMT_RGBA8888	2
@@ -112,6 +126,17 @@ 
#define SUN8I_MIXER_FCC_EN			0xaa000

#define SUN8I_MIXER_DCSC_EN			0xb0000



#define SUN50I_MIXER_FCE_EN			0x70000

#define SUN50I_MIXER_PEAK_EN			0x70800

#define SUN50I_MIXER_LCTI_EN			0x71000

#define SUN50I_MIXER_BLS_EN			0x71800

#define SUN50I_MIXER_FCC_EN			0x72000

#define SUN50I_MIXER_DNS_EN			0x80000

#define SUN50I_MIXER_DRC_EN			0xa0000

#define SUN50I_MIXER_FMT_EN			0xa8000

#define SUN50I_MIXER_CDC0_EN			0xd0000

#define SUN50I_MIXER_CDC1_EN			0xd8000



struct de2_fmt_info {

	u32			drm_fmt;

	u32			de2_fmt;
@@ -133,6 +158,7 @@ struct de2_fmt_info { 
 *	are invalid.

 * @mod_rate: module clock rate that needs to be set in order to have

 *	a functional block.

 * @is_de3: true, if this is next gen display engine 3.0, false otherwise.

 */

struct sun8i_mixer_cfg {

	int		vi_num;
@@ -140,6 +166,7 @@ struct sun8i_mixer_cfg { 
	int		scaler_mask;

	int		ccsc;

	unsigned long	mod_rate;

	unsigned int	is_de3 : 1;

};



struct sun8i_mixer {
@@ -162,12 +189,15 @@ engine_to_sun8i_mixer(struct sunxi_engine *engine) 
static inline u32

sun8i_blender_base(struct sun8i_mixer *mixer)

{

	return DE2_BLD_BASE;

	return mixer->cfg->is_de3 ? DE3_BLD_BASE : DE2_BLD_BASE;

}



static inline u32

sun8i_channel_base(struct sun8i_mixer *mixer, int channel)

{

	if (mixer->cfg->is_de3)

		return DE3_CH_BASE + channel * DE3_CH_SIZE;

	else

		return DE2_CH_BASE + channel * DE2_CH_SIZE;

}

drivers/gpu/drm/sun4i/sun8i_ui_scaler.c

+8 −2
Original line number Diff line number Diff line
@@ -93,7 +93,13 @@ static u32 sun8i_ui_scaler_base(struct sun8i_mixer *mixer, int channel) 
{

	int vi_num = mixer->cfg->vi_num;



	return DE2_VI_SCALER_UNIT_BASE + DE2_VI_SCALER_UNIT_SIZE * vi_num +

	if (mixer->cfg->is_de3)

		return DE3_VI_SCALER_UNIT_BASE +

		       DE3_VI_SCALER_UNIT_SIZE * vi_num +

		       DE3_UI_SCALER_UNIT_SIZE * (channel - vi_num);

	else

		return DE2_VI_SCALER_UNIT_BASE +

		       DE2_VI_SCALER_UNIT_SIZE * vi_num +

		       DE2_UI_SCALER_UNIT_SIZE * (channel - vi_num);

}

drivers/gpu/drm/sun4i/sun8i_ui_scaler.h

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#include "sun8i_mixer.h"



#define DE2_UI_SCALER_UNIT_SIZE 0x10000

#define DE3_UI_SCALER_UNIT_SIZE 0x08000



/* this two macros assumes 16 fractional bits which is standard in DRM */

#define SUN8I_UI_SCALER_SCALE_MIN		1

CRA Git | Maintained and supported by SUSTech CRA and CCSE