Commit c4fc1956 authored Apr 29, 2016 by Tony Luck Committed by Borislav Petkov Apr 29, 2016

EDAC: i7core, sb_edac: Don't return NOTIFY_BAD from mce_decoder callback



Both of these drivers can return NOTIFY_BAD, but this terminates
processing other callbacks that were registered later on the chain.
Since the driver did nothing to log the error it seems wrong to prevent
other interested parties from seeing it. E.g. neither of them had even
bothered to check the type of the error to see if it was a memory error
before the return NOTIFY_BAD.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/72937355dd92318d2630979666063f8a2853495b.1461864507.git.tony.luck@intel.com


Signed-off-by: Borislav Petkov <bp@suse.de>

parent 02da2d72

drivers/edac/i7core_edac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1866,7 +1866,7 @@ static int i7core_mce_check_error(struct notifier_block *nb, unsigned long val,

		i7_dev = get_i7core_dev(mce->socketid);
		if (!i7_dev)
		return NOTIFY_BAD;
		return NOTIFY_DONE;

		mci = i7_dev->mci;
		pvt = mci->pvt_info;

drivers/edac/sb_edac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3168,7 +3168,7 @@ static int sbridge_mce_check_error(struct notifier_block *nb, unsigned long val,

		mci = get_mci_for_node_id(mce->socketid);
		if (!mci)
		return NOTIFY_BAD;
		return NOTIFY_DONE;
		pvt = mci->pvt_info;

		/*

Admin message