Commit c4f30608 authored Nov 10, 2011 by Paul E. McKenney Committed by Paul E. McKenney Dec 11, 2011

sched: Add is_idle_task() to handle invalidated uses of idle_cpu()



Commit 908a3283 (Fix idle_cpu()) invalidated some uses of idle_cpu(),
which used to say whether or not the CPU was running the idle task,
but now instead says whether or not the CPU is running the idle task
in the absence of pending wakeups.  Although this new implementation
gives a better answer to the question "is this CPU idle?", it also
invalidates other uses that were made of idle_cpu().

This commit therefore introduces a new is_idle_task() API member
that determines whether or not the specified task is one of the
idle tasks, allowing open-coded "->pid == 0" sequences to be replaced
by something more meaningful.

Suggested-by: Josh Triplett <josh@joshtriplett.org>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

parent bb3bf705

include/linux/sched.h

+8 −0

Original line number	Diff line number	Diff line
		@@ -2070,6 +2070,14 @@ extern int sched_setscheduler(struct task_struct *, int,
		extern int sched_setscheduler_nocheck(struct task_struct *, int,
		const struct sched_param *);
		extern struct task_struct *idle_task(int cpu);
		/**
		* is_idle_task - is the specified task an idle task?
		* @tsk: the task in question.
		*/
		static inline bool is_idle_task(struct task_struct *p)
		{
		return p->pid == 0;
		}
		extern struct task_struct *curr_task(int cpu);
		extern void set_curr_task(int cpu, struct task_struct *p);

Admin message