Commit c4e401e5 authored Apr 04, 2019 by Huazhong Tan Committed by David S. Miller Apr 04, 2019

net: hns3: check resetting status in hns3_get_stats()



hns3_get_stats() should check the resetting status firstly,
since the device will be reinitialized when resetting. If the
reset has not completed, the hns3_get_stats() may access
invalid memory.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 389775a6

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -483,6 +483,11 @@ static void hns3_get_stats(struct net_device *netdev,
		struct hnae3_handle *h = hns3_get_handle(netdev);
		u64 *p = data;

		if (hns3_nic_resetting(netdev)) {
		netdev_err(netdev, "dev resetting, could not get stats\n");
		return;
		}

		if (!h->ae_algo->ops->get_stats \|\| !h->ae_algo->ops->update_stats) {
		netdev_err(netdev, "could not get any statistics\n");
		return;

Admin message