Commit c4de37ee authored by Peter Oh's avatar Peter Oh Committed by Johannes Berg
Browse files

mac80211: mesh: fix wrong mesh TTL offset calculation 



mesh TTL offset in Mesh Channel Switch Parameters element depends on
not only Secondary Channel Offset element, but also affected by
HT Control field and Wide Bandwidth Channel Switch element.
So use element structure to manipulate mesh channel swich param IE
after removing its constant attribution to correct the miscalculation.

Signed-off-by: default avatarPeter Oh <peter.oh@bowerswilkins.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c028c630

net/mac80211/ieee80211_i.h

+1 −1
Original line number Diff line number Diff line
@@ -1467,7 +1467,7 @@ struct ieee802_11_elems { 
	const struct ieee80211_timeout_interval_ie *timeout_int;

	const u8 *opmode_notif;

	const struct ieee80211_sec_chan_offs_ie *sec_chan_offs;

	const struct ieee80211_mesh_chansw_params_ie *mesh_chansw_params_ie;

	struct ieee80211_mesh_chansw_params_ie *mesh_chansw_params_ie;

	const struct ieee80211_bss_max_idle_period_ie *max_idle_period_ie;



	/* length of them, respectively */

net/mac80211/mesh.c

+6 −11
Original line number Diff line number Diff line
@@ -1253,13 +1253,12 @@ int ieee80211_mesh_csa_beacon(struct ieee80211_sub_if_data *sdata, 
}



static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata,

			       struct ieee80211_mgmt *mgmt, size_t len)

			       struct ieee80211_mgmt *mgmt, size_t len,

			       struct ieee802_11_elems *elems)

{

	struct ieee80211_mgmt *mgmt_fwd;

	struct sk_buff *skb;

	struct ieee80211_local *local = sdata->local;

	u8 *pos = mgmt->u.action.u.chan_switch.variable;

	size_t offset_ttl;



	skb = dev_alloc_skb(local->tx_headroom + len);

	if (!skb)
@@ -1267,13 +1266,9 @@ static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata, 
	skb_reserve(skb, local->tx_headroom);

	mgmt_fwd = skb_put(skb, len);



	/* offset_ttl is based on whether the secondary channel

	 * offset is available or not. Subtract 1 from the mesh TTL

	 * and disable the initiator flag before forwarding.

	 */

	offset_ttl = (len < 42) ? 7 : 10;

	*(pos + offset_ttl) -= 1;

	*(pos + offset_ttl + 1) &= ~WLAN_EID_CHAN_SWITCH_PARAM_INITIATOR;

	elems->mesh_chansw_params_ie->mesh_ttl--;

	elems->mesh_chansw_params_ie->mesh_flags &=

		~WLAN_EID_CHAN_SWITCH_PARAM_INITIATOR;



	memcpy(mgmt_fwd, mgmt, len);

	eth_broadcast_addr(mgmt_fwd->da);
@@ -1321,7 +1316,7 @@ static void mesh_rx_csa_frame(struct ieee80211_sub_if_data *sdata, 


	/* forward or re-broadcast the CSA frame */

	if (fwd_csa) {

		if (mesh_fwd_csa_frame(sdata, mgmt, len) < 0)

		if (mesh_fwd_csa_frame(sdata, mgmt, len, &elems) < 0)

			mcsa_dbg(sdata, "Failed to forward the CSA frame");

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE