Commit c4bf2f37 authored by Len Brown's avatar Len Brown
Browse files

ACPI, PCI, x86: move MCFG parsing routine from ACPI to PCI file 



Move
arch/x86/kernel/acpi/boot.c: acpi_parse_mcfg()
to
arch/x86/pci/mmconfig-shared.c: pci_parse_mcfg()
where it is used, and make it static.

Move associated globals and helper routine with it.

No functional change.

This code move is in preparation for SFI support,
which will allow the PCI code to find the MCFG table
on systems which do not support ACPI.

Signed-off-by: default avatarLen Brown <len.brown@intel.com>
Acked-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 24c5c4c2

arch/x86/include/asm/pci_x86.h

+3 −0
Original line number Diff line number Diff line
@@ -121,6 +121,9 @@ extern int __init pcibios_init(void); 
extern int __init pci_mmcfg_arch_init(void);

extern void __init pci_mmcfg_arch_free(void);



extern struct acpi_mcfg_allocation *pci_mmcfg_config;

extern int pci_mmcfg_config_num;



/*

 * AMD Fam10h CPUs are buggy, and cannot access MMIO config space

 * on their northbrige except through the * %eax register. As such, you MUST

arch/x86/kernel/acpi/boot.c

+0 −66
Original line number Diff line number Diff line
@@ -117,72 +117,6 @@ void __init __acpi_unmap_table(char *map, unsigned long size) 
	early_iounmap(map, size);

}



#ifdef CONFIG_PCI_MMCONFIG



static int acpi_mcfg_64bit_base_addr __initdata = FALSE;



/* The physical address of the MMCONFIG aperture.  Set from ACPI tables. */

struct acpi_mcfg_allocation *pci_mmcfg_config;

int pci_mmcfg_config_num;



static int __init acpi_mcfg_oem_check(struct acpi_table_mcfg *mcfg)

{

	if (!strcmp(mcfg->header.oem_id, "SGI"))

		acpi_mcfg_64bit_base_addr = TRUE;



	return 0;

}



int __init acpi_parse_mcfg(struct acpi_table_header *header)

{

	struct acpi_table_mcfg *mcfg;

	unsigned long i;

	int config_size;



	if (!header)

		return -EINVAL;



	mcfg = (struct acpi_table_mcfg *)header;



	/* how many config structures do we have */

	pci_mmcfg_config_num = 0;

	i = header->length - sizeof(struct acpi_table_mcfg);

	while (i >= sizeof(struct acpi_mcfg_allocation)) {

		++pci_mmcfg_config_num;

		i -= sizeof(struct acpi_mcfg_allocation);

	};

	if (pci_mmcfg_config_num == 0) {

		printk(KERN_ERR PREFIX "MMCONFIG has no entries\n");

		return -ENODEV;

	}



	config_size = pci_mmcfg_config_num * sizeof(*pci_mmcfg_config);

	pci_mmcfg_config = kmalloc(config_size, GFP_KERNEL);

	if (!pci_mmcfg_config) {

		printk(KERN_WARNING PREFIX

		       "No memory for MCFG config tables\n");

		return -ENOMEM;

	}



	memcpy(pci_mmcfg_config, &mcfg[1], config_size);



	acpi_mcfg_oem_check(mcfg);



	for (i = 0; i < pci_mmcfg_config_num; ++i) {

		if ((pci_mmcfg_config[i].address > 0xFFFFFFFF) &&

		    !acpi_mcfg_64bit_base_addr) {

			printk(KERN_ERR PREFIX

			       "MMCONFIG not in low 4GB of memory\n");

			kfree(pci_mmcfg_config);

			pci_mmcfg_config_num = 0;

			return -ENODEV;

		}

	}



	return 0;

}

#endif				/* CONFIG_PCI_MMCONFIG */



#ifdef CONFIG_X86_LOCAL_APIC

static int __init acpi_parse_madt(struct acpi_table_header *table)

{

arch/x86/pci/mmconfig-shared.c

+64 −1
Original line number Diff line number Diff line
@@ -523,6 +523,69 @@ reject: 


static int __initdata known_bridge;



static int acpi_mcfg_64bit_base_addr __initdata = FALSE;



/* The physical address of the MMCONFIG aperture.  Set from ACPI tables. */

struct acpi_mcfg_allocation *pci_mmcfg_config;

int pci_mmcfg_config_num;



static int __init acpi_mcfg_oem_check(struct acpi_table_mcfg *mcfg)

{

	if (!strcmp(mcfg->header.oem_id, "SGI"))

		acpi_mcfg_64bit_base_addr = TRUE;



	return 0;

}



static int __init pci_parse_mcfg(struct acpi_table_header *header)

{

	struct acpi_table_mcfg *mcfg;

	unsigned long i;

	int config_size;



	if (!header)

		return -EINVAL;



	mcfg = (struct acpi_table_mcfg *)header;



	/* how many config structures do we have */

	pci_mmcfg_config_num = 0;

	i = header->length - sizeof(struct acpi_table_mcfg);

	while (i >= sizeof(struct acpi_mcfg_allocation)) {

		++pci_mmcfg_config_num;

		i -= sizeof(struct acpi_mcfg_allocation);

	};

	if (pci_mmcfg_config_num == 0) {

		printk(KERN_ERR PREFIX "MMCONFIG has no entries\n");

		return -ENODEV;

	}



	config_size = pci_mmcfg_config_num * sizeof(*pci_mmcfg_config);

	pci_mmcfg_config = kmalloc(config_size, GFP_KERNEL);

	if (!pci_mmcfg_config) {

		printk(KERN_WARNING PREFIX

		       "No memory for MCFG config tables\n");

		return -ENOMEM;

	}



	memcpy(pci_mmcfg_config, &mcfg[1], config_size);



	acpi_mcfg_oem_check(mcfg);



	for (i = 0; i < pci_mmcfg_config_num; ++i) {

		if ((pci_mmcfg_config[i].address > 0xFFFFFFFF) &&

		    !acpi_mcfg_64bit_base_addr) {

			printk(KERN_ERR PREFIX

			       "MMCONFIG not in low 4GB of memory\n");

			kfree(pci_mmcfg_config);

			pci_mmcfg_config_num = 0;

			return -ENODEV;

		}

	}



	return 0;

}



static void __init __pci_mmcfg_init(int early)

{

	/* MMCONFIG disabled */
@@ -543,7 +606,7 @@ static void __init __pci_mmcfg_init(int early) 
	}



	if (!known_bridge)

		acpi_table_parse(ACPI_SIG_MCFG, acpi_parse_mcfg);

		acpi_table_parse(ACPI_SIG_MCFG, pci_parse_mcfg);



	pci_mmcfg_reject_broken(early);

include/linux/acpi.h

+0 −3
Original line number Diff line number Diff line
@@ -113,9 +113,6 @@ void acpi_irq_stats_init(void); 
extern u32 acpi_irq_handled;

extern u32 acpi_irq_not_handled;



extern struct acpi_mcfg_allocation *pci_mmcfg_config;

extern int pci_mmcfg_config_num;



extern int sbf_port;

extern unsigned long acpi_realmode_flags;

CRA Git | Maintained and supported by SUSTech CRA and CCSE