Commit c4a359a0 authored Jan 13, 2016 by Takashi Iwai

ALSA: usb-audio: Fix mixer ctl regression of Native Instrument devices



The commit [da6d2769: ALSA: usb-audio: Add resume support for
Native Instruments controls] brought a regression where the Native
Instrument audio devices don't get the correct value at update due to
the missing shift at writing.  This patch addresses it.

Fixes: da6d2769 ('ALSA: usb-audio: Add resume support for Native Instruments controls')
Reported-and-tested-by: Owen Williams <owilliams@mixxx.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 0a1f90a9

sound/usb/mixer_quirks.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -793,7 +793,7 @@ static int snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol,
		return 0;

		kcontrol->private_value &= ~(0xff << 24);
		kcontrol->private_value \|= newval;
		kcontrol->private_value \|= (unsigned int)newval << 24;
		err = snd_ni_update_cur_val(list);
		return err < 0 ? err : 1;
		}

Admin message