Commit c49a9440 authored by Parav Pandit's avatar Parav Pandit Committed by David S. Miller
Browse files

devlink: Enhance policy to validate port type input value 



Use range checking facility of nla_policy to validate port type
attribute input value is valid or not.

Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ba356c90

net/core/devlink.c

+2 −3
Original line number Diff line number Diff line
@@ -811,8 +811,6 @@ static int devlink_port_type_set(struct devlink *devlink, 
	int err;



	if (devlink->ops->port_type_set) {

		if (port_type == DEVLINK_PORT_TYPE_NOTSET)

			return -EINVAL;

		if (port_type == devlink_port->type)

			return 0;

		err = devlink->ops->port_type_set(devlink_port, port_type);
@@ -7055,7 +7053,8 @@ static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = { 
	[DEVLINK_ATTR_BUS_NAME] = { .type = NLA_NUL_STRING },

	[DEVLINK_ATTR_DEV_NAME] = { .type = NLA_NUL_STRING },

	[DEVLINK_ATTR_PORT_INDEX] = { .type = NLA_U32 },

	[DEVLINK_ATTR_PORT_TYPE] = { .type = NLA_U16 },

	[DEVLINK_ATTR_PORT_TYPE] = NLA_POLICY_RANGE(NLA_U16, DEVLINK_PORT_TYPE_AUTO,

						    DEVLINK_PORT_TYPE_IB),

	[DEVLINK_ATTR_PORT_SPLIT_COUNT] = { .type = NLA_U32 },

	[DEVLINK_ATTR_SB_INDEX] = { .type = NLA_U32 },

	[DEVLINK_ATTR_SB_POOL_INDEX] = { .type = NLA_U16 },

CRA Git | Maintained and supported by SUSTech CRA and CCSE