crypto: mxs - Remove the old DCP driver (c493c044) · Commits · 戴 / test

Remove the old DCP driver as it had multiple severe issues. The driver will be replaced by a more robust implementation. Here is a short list of problems with this driver: 1) It only supports AES_CBC 2) The driver was apparently never ran behind anyone working with MXS. ie.: -> Restarting the DCP block is not done via mxs_reset_block() -> The DT name is not "fsl,dcp" or "fsl,mxs-dcp" as other MXS drivers 3) Introduces new ad-hoc IOCTLs 4) The IRQ handler can't use usual completion() in the driver because that'd trigger "scheduling while atomic" oops, yes? Signed-off-by:

Marek Vasut <marex@denx.de> Cc: David S. Miller <davem@davemloft.net> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Shawn Guo <shawn.guo@linaro.org> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

drivers/crypto/Kconfig

+0 −10

Original line number	Diff line number	Diff line
		@@ -289,16 +289,6 @@ config CRYPTO_DEV_SAHARA
		This option enables support for the SAHARA HW crypto accelerator
		found in some Freescale i.MX chips.

		config CRYPTO_DEV_DCP
		tristate "Support for the DCP engine"
		depends on ARCH_MXS && OF
		select CRYPTO_BLKCIPHER
		select CRYPTO_AES
		select CRYPTO_CBC
		help
		This options enables support for the hardware crypto-acceleration
		capabilities of the DCP co-processor

		config CRYPTO_DEV_S5P
		tristate "Support for Samsung S5PV210 crypto accelerator"
		depends on ARCH_S5PV210

drivers/crypto/Makefile

+0 −1

Original line number	Diff line number	Diff line
		@@ -13,7 +13,6 @@ obj-$(CONFIG_CRYPTO_DEV_OMAP_SHAM) += omap-sham.o
		obj-$(CONFIG_CRYPTO_DEV_OMAP_AES) += omap-aes.o
		obj-$(CONFIG_CRYPTO_DEV_PICOXCELL) += picoxcell_crypto.o
		obj-$(CONFIG_CRYPTO_DEV_SAHARA) += sahara.o
		obj-$(CONFIG_CRYPTO_DEV_DCP) += dcp.o
		obj-$(CONFIG_CRYPTO_DEV_S5P) += s5p-sss.o
		obj-$(CONFIG_CRYPTO_DEV_TEGRA_AES) += tegra-aes.o
		obj-$(CONFIG_CRYPTO_DEV_UX500) += ux500/

drivers/crypto/dcp.c

deleted100644 → 0

+0 −903

File deleted.

Preview size limit exceeded, changes collapsed.

Admin message