Commit c493b09b authored Mar 24, 2019 by Jiri Pirko Committed by David S. Miller Mar 26, 2019

net: devlink: skip info_get op call if it is not defined in dumpit



In dumpit, unlike doit, the check for info_get op being defined
is missing. Add it and avoid null pointer dereference in case driver
does not define this op.

Fixes: f9cf2288 ("devlink: add device information API")
Reported-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 450895d0

net/core/devlink.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -3897,6 +3897,11 @@ static int devlink_nl_cmd_info_get_dumpit(struct sk_buff *msg,
		continue;
		}

		if (!devlink->ops->info_get) {
		idx++;
		continue;
		}

		mutex_lock(&devlink->lock);
		err = devlink_nl_info_fill(msg, devlink, DEVLINK_CMD_INFO_GET,
		NETLINK_CB(cb->skb).portid,

Admin message