Commit c46fff2a authored by Frederic Weisbecker's avatar Frederic Weisbecker Committed by Jens Axboe
Browse files

smp: Rename __smp_call_function_single() to smp_call_function_single_async() 



The name __smp_call_function_single() doesn't tell much about the
properties of this function, especially when compared to
smp_call_function_single().

The comments above the implementation are also misleading. The main
point of this function is actually not to be able to embed the csd
in an object. This is actually a requirement that result from the
purpose of this function which is to raise an IPI asynchronously.

As such it can be called with interrupts disabled. And this feature
comes at the cost of the caller who then needs to serialize the
IPIs on this csd.

Lets rename the function and enhance the comments so that they reflect
these properties.

Suggested-by: default avatarChristoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@fb.com>
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent fce8ad15

block/blk-mq.c

+1 −1
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ void __blk_mq_complete_request(struct request *rq) 
		rq->csd.func = __blk_mq_complete_request_remote;

		rq->csd.info = rq;

		rq->csd.flags = 0;

		__smp_call_function_single(ctx->cpu, &rq->csd);

		smp_call_function_single_async(ctx->cpu, &rq->csd);

	} else {

		rq->q->softirq_done_fn(rq);

	}

block/blk-softirq.c

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ static int raise_blk_irq(int cpu, struct request *rq) 
		data->info = rq;

		data->flags = 0;



		__smp_call_function_single(cpu, data);

		smp_call_function_single_async(cpu, data);

		return 0;

	}

drivers/cpuidle/coupled.c

+1 −1
Original line number Diff line number Diff line
@@ -323,7 +323,7 @@ static void cpuidle_coupled_poke(int cpu) 
	struct call_single_data *csd = &per_cpu(cpuidle_coupled_poke_cb, cpu);



	if (!cpumask_test_and_set_cpu(cpu, &cpuidle_coupled_poke_pending))

		__smp_call_function_single(cpu, csd);

		smp_call_function_single_async(cpu, csd);

}



/**

include/linux/smp.h

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ void on_each_cpu_cond(bool (*cond_func)(int cpu, void *info), 
		smp_call_func_t func, void *info, bool wait,

		gfp_t gfp_flags);



int __smp_call_function_single(int cpu, struct call_single_data *csd);

int smp_call_function_single_async(int cpu, struct call_single_data *csd);



#ifdef CONFIG_SMP

kernel/sched/core.c

+1 −1
Original line number Diff line number Diff line
@@ -432,7 +432,7 @@ void hrtick_start(struct rq *rq, u64 delay) 
	if (rq == this_rq()) {

		__hrtick_restart(rq);

	} else if (!rq->hrtick_csd_pending) {

		__smp_call_function_single(cpu_of(rq), &rq->hrtick_csd);

		smp_call_function_single_async(cpu_of(rq), &rq->hrtick_csd);

		rq->hrtick_csd_pending = 1;

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE