Commit c46ab9db authored by Georgi Djakov's avatar Georgi Djakov
Browse files

interconnect: Add basic tracepoints 



The tracepoints can help with understanding the system behavior of a
given interconnect path when the consumer drivers change their bandwidth
demands. This might be interesting when we want to monitor the requested
interconnect bandwidth for each client driver. The paths may share the
same nodes and this will help to understand "who and when is requesting
what". All this is useful for subsystem drivers developers and may also
provide hints when optimizing the power and performance profile of the
system.

Reviewed-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarGeorgi Djakov <georgi.djakov@linaro.org>
parent 05309830

drivers/interconnect/Makefile

+1 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0



CFLAGS_core.o				:= -I$(src)

icc-core-objs				:= core.o



obj-$(CONFIG_INTERCONNECT)		+= icc-core.o

drivers/interconnect/core.c

+7 −0
Original line number Diff line number Diff line
@@ -21,6 +21,9 @@ 


#include "internal.h"



#define CREATE_TRACE_POINTS

#include "trace.h"



static DEFINE_IDR(icc_idr);

static LIST_HEAD(icc_providers);

static DEFINE_MUTEX(icc_lock);
@@ -435,6 +438,8 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw) 


		/* aggregate requests for this node */

		aggregate_requests(node);



		trace_icc_set_bw(path, node, i, avg_bw, peak_bw);

	}



	ret = apply_constraints(path);
@@ -453,6 +458,8 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw) 


	mutex_unlock(&icc_lock);



	trace_icc_set_bw_end(path, ret);



	return ret;

}

EXPORT_SYMBOL_GPL(icc_set_bw);

drivers/interconnect/trace.h

0 → 100644
+88 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

/*

 * Interconnect framework tracepoints

 * Copyright (c) 2019, Linaro Ltd.

 * Author: Georgi Djakov <georgi.djakov@linaro.org>

 */



#undef TRACE_SYSTEM

#define TRACE_SYSTEM interconnect



#if !defined(_TRACE_INTERCONNECT_H) || defined(TRACE_HEADER_MULTI_READ)

#define _TRACE_INTERCONNECT_H



#include <linux/interconnect.h>

#include <linux/tracepoint.h>



TRACE_EVENT(icc_set_bw,



	TP_PROTO(struct icc_path *p, struct icc_node *n, int i,

		 u32 avg_bw, u32 peak_bw),



	TP_ARGS(p, n, i, avg_bw, peak_bw),



	TP_STRUCT__entry(

		__string(path_name, p->name)

		__string(dev, dev_name(p->reqs[i].dev))

		__string(node_name, n->name)

		__field(u32, avg_bw)

		__field(u32, peak_bw)

		__field(u32, node_avg_bw)

		__field(u32, node_peak_bw)

	),



	TP_fast_assign(

		__assign_str(path_name, p->name);

		__assign_str(dev, dev_name(p->reqs[i].dev));

		__assign_str(node_name, n->name);

		__entry->avg_bw = avg_bw;

		__entry->peak_bw = peak_bw;

		__entry->node_avg_bw = n->avg_bw;

		__entry->node_peak_bw = n->peak_bw;

	),



	TP_printk("path=%s dev=%s node=%s avg_bw=%u peak_bw=%u agg_avg=%u agg_peak=%u",

		  __get_str(path_name),

		  __get_str(dev),

		  __get_str(node_name),

		  __entry->avg_bw,

		  __entry->peak_bw,

		  __entry->node_avg_bw,

		  __entry->node_peak_bw)

);



TRACE_EVENT(icc_set_bw_end,



	TP_PROTO(struct icc_path *p, int ret),



	TP_ARGS(p, ret),



	TP_STRUCT__entry(

		__string(path_name, p->name)

		__string(dev, dev_name(p->reqs[0].dev))

		__field(int, ret)

	),



	TP_fast_assign(

		__assign_str(path_name, p->name);

		__assign_str(dev, dev_name(p->reqs[0].dev));

		__entry->ret = ret;

	),



	TP_printk("path=%s dev=%s ret=%d",

		  __get_str(path_name),

		  __get_str(dev),

		  __entry->ret)

);



#endif /* _TRACE_INTERCONNECT_H */



/* This part must be outside protection */



#undef TRACE_INCLUDE_PATH

#define TRACE_INCLUDE_PATH .



#undef TRACE_INCLUDE_FILE

#define TRACE_INCLUDE_FILE trace



#include <trace/define_trace.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE