Unverified Commit c46652ee authored Oct 09, 2019 by zhengbin Committed by Mark Brown Oct 09, 2019

spi: npcm: Remove set but not used variable 'val'



Fixes gcc '-Wunused-but-set-variable' warning:

drivers/spi/spi-npcm-pspi.c: In function npcm_pspi_handler:
drivers/spi/spi-npcm-pspi.c:296:6: warning: variable val set but not used [-Wunused-but-set-variable]

It is not used since commit 2a22f1b3 ("spi:
npcm: add NPCM PSPI controller driver")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Link: https://lore.kernel.org/r/1570581437-104549-3-git-send-email-zhengbin13@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 944be39b

drivers/spi/spi-npcm-pspi.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -293,7 +293,6 @@ static void npcm_pspi_reset_hw(struct npcm_pspi *priv)
		static irqreturn_t npcm_pspi_handler(int irq, void *dev_id)
		{
		struct npcm_pspi *priv = dev_id;
		u16 val;
		u8 stat;

		stat = ioread8(priv->base + NPCM_PSPI_STAT);
		@@ -303,7 +302,7 @@ static irqreturn_t npcm_pspi_handler(int irq, void *dev_id)

		if (priv->tx_buf) {
		if (stat & NPCM_PSPI_STAT_RBF) {
		val = ioread8(NPCM_PSPI_DATA + priv->base);
		ioread8(NPCM_PSPI_DATA + priv->base);
		if (priv->tx_bytes == 0) {
		npcm_pspi_disable(priv);
		complete(&priv->xfer_done);

Admin message