Commit c43f28df authored Aug 04, 2019 by Gavin Li Committed by Greg Kroah-Hartman Aug 05, 2019

usb: usbfs: fix double-free of usb memory upon submiturb error



Upon an error within proc_do_submiturb(), dec_usb_memory_use_count()
gets called once by the error handling tail and again by free_async().
Remove the first call.

Signed-off-by: Gavin Li <git@thegavinli.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190804235044.22327-1-gavinli@thegavinli.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fc05481b

drivers/usb/core/devio.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1812,8 +1812,6 @@ static int proc_do_submiturb(struct usb_dev_state ps, struct usbdevfs_urb uurb
	return 0;		return 0;

	error:		error:
	if (as && as->usbm)
	dec_usb_memory_use_count(as->usbm, &as->usbm->urb_use_count);
	kfree(isopkt);		kfree(isopkt);
	kfree(dr);		kfree(dr);
	if (as)		if (as)

Admin message