Commit c43ac97b authored Mar 28, 2019 by Jakub Kicinski Committed by David S. Miller Mar 29, 2019

net: tls: prevent false connection termination with offload



Only decrypt_internal() performs zero copy on rx, all paths
which don't hit decrypt_internal() must set zc to false,
otherwise tls_sw_recvmsg() may return 0 causing the application
to believe that that connection got closed.

Currently this happens with device offload when new record
is first read from.

Fixes: d069b780 ("tls: Fix tls_device receive")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Reported-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1b704c4a

net/tls/tls_sw.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1484,6 +1484,8 @@ static int decrypt_skb_update(struct sock sk, struct sk_buff skb,

		return err;
		}
		} else {
		*zc = false;
		}

		rxm->full_len -= padding_length(ctx, tls_ctx, skb);

Admin message