Commit c430ca1e authored by Thierry MERLE's avatar Thierry MERLE Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (5019): Fix the frame->grabstate update in read() entry point. 



The Coverity checker spotted that in usbvision_v4l2_read(), the variable
"frmx" is never assigned any value different from -1, but it's used an 
an array index in "usbvision->frame[frmx]".
Thanks to Adrian Bunk <bunk@stusta.de> for warning about that.

Signed-off-by: default avatarThierry MERLE <thierry.merle@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent a8b34852

drivers/media/video/usbvision/usbvision-video.c

+1 −2
Original line number Diff line number Diff line
@@ -1080,7 +1080,6 @@ static ssize_t usbvision_v4l2_read(struct file *file, char *buf, 
	int noblock = file->f_flags & O_NONBLOCK;

	unsigned long lock_flags;



	int frmx = -1;

	int ret,i;

	struct usbvision_frame *frame;
@@ -1155,7 +1154,7 @@ static ssize_t usbvision_v4l2_read(struct file *file, char *buf, 
		frame->bytes_read = 0;



		/* Mark it as available to be used again. */

		usbvision->frame[frmx].grabstate = FrameState_Unused;

		frame->grabstate = FrameState_Unused;

/* 	} */



	return count;

CRA Git | Maintained and supported by SUSTech CRA and CCSE