Commit c42b110c authored Jul 29, 2009 by Pawel Osciak Committed by Linus Torvalds Jul 29, 2009

s3c-fb: fix off-by-one bug in loop indexes



Fixed off-by-one bug in loop indexes - some elements beyond windows' array
were accessed, which might result in memory access violations when
removing/suspending the device.

Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3d768213

drivers/video/s3c-fb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -964,7 +964,7 @@ static int __devexit s3c_fb_remove(struct platform_device *pdev)
		struct s3c_fb *sfb = platform_get_drvdata(pdev);
		int win;

		for (win = 0; win <= S3C_FB_MAX_WIN; win++)
		for (win = 0; win < S3C_FB_MAX_WIN; win++)
		if (sfb->windows[win])
		s3c_fb_release_win(sfb, sfb->windows[win]);

		@@ -988,7 +988,7 @@ static int s3c_fb_suspend(struct platform_device *pdev, pm_message_t state)
		struct s3c_fb_win *win;
		int win_no;

		for (win_no = S3C_FB_MAX_WIN; win_no >= 0; win_no--) {
		for (win_no = S3C_FB_MAX_WIN - 1; win_no >= 0; win_no--) {
		win = sfb->windows[win_no];
		if (!win)
		continue;

Admin message