Commit c41784b0 authored by Cheng-Yi Chiang's avatar Cheng-Yi Chiang Committed by Neil Armstrong
Browse files

drm: dw-hdmi-i2s: enable audio clock in audio_startup 



In the designware databook, the sequence of enabling audio clock and
setting format is not clearly specified.
Currently, audio clock is enabled in the end of hw_param ops after
setting format.

On some monitors, there is a possibility that audio does not come out.
Fix this by enabling audio clock in audio_startup ops
before hw_param ops setting format.

Signed-off-by: default avatarCheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarJonas Karlman <jonas@kwiboo.se>
Tested-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190902035435.44463-1-cychiang@chromium.org
parent 268de653

drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c

+9 −0
Original line number Diff line number Diff line
@@ -109,6 +109,14 @@ static int dw_hdmi_i2s_hw_params(struct device *dev, void *data, 
	hdmi_write(audio, conf0, HDMI_AUD_CONF0);

	hdmi_write(audio, conf1, HDMI_AUD_CONF1);



	return 0;

}



static int dw_hdmi_i2s_audio_startup(struct device *dev, void *data)

{

	struct dw_hdmi_i2s_audio_data *audio = data;

	struct dw_hdmi *hdmi = audio->hdmi;



	dw_hdmi_audio_enable(hdmi);



	return 0;
@@ -153,6 +161,7 @@ static int dw_hdmi_i2s_get_dai_id(struct snd_soc_component *component, 


static struct hdmi_codec_ops dw_hdmi_i2s_ops = {

	.hw_params	= dw_hdmi_i2s_hw_params,

	.audio_startup  = dw_hdmi_i2s_audio_startup,

	.audio_shutdown	= dw_hdmi_i2s_audio_shutdown,

	.get_eld	= dw_hdmi_i2s_get_eld,

	.get_dai_id	= dw_hdmi_i2s_get_dai_id,

CRA Git | Maintained and supported by SUSTech CRA and CCSE