Commit c411cc88 authored Nov 29, 2011 by Thomas Meyer Committed by Miklos Szeredi Dec 13, 2011

fuse: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>

parent c07c3d19

fs/fuse/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1776,7 +1776,7 @@ long fuse_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg,
		BUILD_BUG_ON(sizeof(struct fuse_ioctl_iovec) * FUSE_IOCTL_MAX_IOV > PAGE_SIZE);

		err = -ENOMEM;
		pages = kzalloc(sizeof(pages[0]) * FUSE_MAX_PAGES_PER_REQ, GFP_KERNEL);
		pages = kcalloc(FUSE_MAX_PAGES_PER_REQ, sizeof(pages[0]), GFP_KERNEL);
		iov_page = (struct iovec *) __get_free_page(GFP_KERNEL);
		if (!pages \|\| !iov_page)
		goto out;

Admin message