Commit c3f4a6c3 authored May 21, 2019 by Jakub Kicinski Committed by David S. Miller May 22, 2019

net/tls: don't ignore netdev notifications if no TLS features



On device surprise removal path (the notifier) we can't
bail just because the features are disabled.  They may
have been enabled during the lifetime of the device.
This bug leads to leaking netdev references and
use-after-frees if there are active connections while
device features are cleared.

Fixes: e8f69799 ("net/tls: Add generic NIC offload infrastructure")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3686637e

net/tls/tls_device.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -997,7 +997,8 @@ static int tls_dev_event(struct notifier_block *this, unsigned long event,
		{
		struct net_device *dev = netdev_notifier_info_to_dev(ptr);

		if (!(dev->features & (NETIF_F_HW_TLS_RX \| NETIF_F_HW_TLS_TX)))
		if (!dev->tlsdev_ops &&
		!(dev->features & (NETIF_F_HW_TLS_RX \| NETIF_F_HW_TLS_TX)))
		return NOTIFY_DONE;

		switch (event) {

Admin message