Commit c3f4a168 authored Jun 13, 2015 by Filipe Manana Committed by Chris Mason Jun 30, 2015

Btrfs: use kmem_cache_free when freeing entry in inode cache



The free space entries are allocated using kmem_cache_zalloc(),
through __btrfs_add_free_space(), therefore we should use
kmem_cache_free() and not kfree() to avoid any confusion and
any potential problem. Looking at the kfree() definition at
mm/slab.c it has the following comment:

  /*
   * (...)
   *
   * Don't free memory not originally allocated by kmalloc()
   * or you will run into trouble.
   */

So better be safe and use kmem_cache_free().

Cc: stable@vger.kernel.org
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>

parent 67c5e7d4

fs/btrfs/inode-map.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -271,7 +271,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root)
		__btrfs_add_free_space(ctl, info->offset, count);
		free:
		rb_erase(&info->offset_index, rbroot);
		kfree(info);
		kmem_cache_free(btrfs_free_space_cachep, info);
		}
		}

Admin message