Commit c3df30a0 authored Nov 10, 2019 by Navid Emamdoost Committed by Mauro Carvalho Chehab Nov 10, 2019

media: aspeed-video: Fix memory leaks in aspeed_video_probe



In the implementation of aspeed_video_probe() the allocated memory for
video should be released if either devm_ioremap_resource()
or aspeed_video_init() or aspeed_video_setup_video() fails. Replace
kzalloc() with devm_kzalloc to avoid explicit release for video.

Fixes: d2b4387f ("media: platform: Add Aspeed Video Engine driver")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

parent 99cf8a70

drivers/media/platform/aspeed-video.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1657,7 +1657,8 @@ static int aspeed_video_probe(struct platform_device *pdev)
		{
		int rc;
		struct resource *res;
		struct aspeed_video video = kzalloc(sizeof(video), GFP_KERNEL);
		struct aspeed_video *video =
		devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL);

		if (!video)
		return -ENOMEM;

Admin message