staging: comedi: dyna_pci10xx: remove manual legacy attach (c3b52d46) · Commits · 戴 / test

This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/dyna_pci10xx.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -253,15 +253,6 @@ static int dyna_pci10xx_attach_pci(struct comedi_device *dev,
		return 0;
		}

		static int dyna_pci10xx_attach(struct comedi_device *dev,
		struct comedi_devconfig *it)
		{
		dev_warn(dev->class_dev,
		"This driver does not support attach using comedi_config\n");

		return -ENOSYS;
		}

		static void dyna_pci10xx_detach(struct comedi_device *dev)
		{
		struct pci_dev *pcidev = comedi_to_pci_dev(dev);
		@@ -278,7 +269,6 @@ static void dyna_pci10xx_detach(struct comedi_device *dev)
		static struct comedi_driver dyna_pci10xx_driver = {
		.driver_name = "dyna_pci10xx",
		.module = THIS_MODULE,
		.attach = dyna_pci10xx_attach,
		.attach_pci = dyna_pci10xx_attach_pci,
		.detach = dyna_pci10xx_detach,
		};

Admin message