Commit c3b44a06 authored by Suman Anna's avatar Suman Anna Committed by Joerg Roedel
Browse files

iommu/omap: add logic to save/restore locked TLBs 



The MMUs provide a mechanism to lock TLB entries to avoid
eviction and fetching of frequently used page table entries.
These TLBs lose context when the MMUs are turned OFF. Add the
logic to save and restore these locked TLBS during suspend
and resume respectively. There are no locked TLBs during
initial power ON, and they need not be saved during final
shutdown.

Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent db8918f6

drivers/iommu/omap-iommu.c

+58 −3
Original line number Diff line number Diff line
@@ -883,15 +883,55 @@ static void omap_iommu_detach(struct omap_iommu *obj) 


	dma_unmap_single(obj->dev, obj->pd_dma, IOPGD_TABLE_SIZE,

			 DMA_TO_DEVICE);

	iommu_disable(obj);

	obj->pd_dma = 0;

	obj->iopgd = NULL;

	iommu_disable(obj);



	spin_unlock(&obj->iommu_lock);



	dev_dbg(obj->dev, "%s: %s\n", __func__, obj->name);

}



static void omap_iommu_save_tlb_entries(struct omap_iommu *obj)

{

	struct iotlb_lock lock;

	struct cr_regs cr;

	struct cr_regs *tmp;

	int i;



	/* check if there are any locked tlbs to save */

	iotlb_lock_get(obj, &lock);

	obj->num_cr_ctx = lock.base;

	if (!obj->num_cr_ctx)

		return;



	tmp = obj->cr_ctx;

	for_each_iotlb_cr(obj, obj->num_cr_ctx, i, cr)

		* tmp++ = cr;

}



static void omap_iommu_restore_tlb_entries(struct omap_iommu *obj)

{

	struct iotlb_lock l;

	struct cr_regs *tmp;

	int i;



	/* no locked tlbs to restore */

	if (!obj->num_cr_ctx)

		return;



	l.base = 0;

	tmp = obj->cr_ctx;

	for (i = 0; i < obj->num_cr_ctx; i++, tmp++) {

		l.vict = i;

		iotlb_lock_set(obj, &l);

		iotlb_load_cr(obj, tmp);

	}

	l.base = obj->num_cr_ctx;

	l.vict = i;

	iotlb_lock_set(obj, &l);

}



/**

 * omap_iommu_runtime_suspend - disable an iommu device

 * @dev:	iommu device
@@ -901,7 +941,8 @@ static void omap_iommu_detach(struct omap_iommu *obj) 
 * device, or during system/runtime suspend of the device. This

 * includes programming all the appropriate IOMMU registers, and

 * managing the associated omap_hwmod's state and the device's

 * reset line.

 * reset line. This function also saves the context of any

 * locked TLBs if suspending.

 **/

static int omap_iommu_runtime_suspend(struct device *dev)

{
@@ -910,6 +951,10 @@ static int omap_iommu_runtime_suspend(struct device *dev) 
	struct omap_iommu *obj = to_iommu(dev);

	int ret;



	/* save the TLBs only during suspend, and not for power down */

	if (obj->domain && obj->iopgd)

		omap_iommu_save_tlb_entries(obj);



	omap2_iommu_disable(obj);



	if (pdata && pdata->device_idle)
@@ -938,7 +983,8 @@ static int omap_iommu_runtime_suspend(struct device *dev) 
 * device, or during system/runtime resume of the device. This

 * includes programming all the appropriate IOMMU registers, and

 * managing the associated omap_hwmod's state and the device's

 * reset line.

 * reset line. The function also restores any locked TLBs if

 * resuming after a suspend.

 **/

static int omap_iommu_runtime_resume(struct device *dev)

{
@@ -966,6 +1012,10 @@ static int omap_iommu_runtime_resume(struct device *dev) 
	if (pdata && pdata->device_enable)

		pdata->device_enable(pdev);



	/* restore the TLBs only during resume, and not for power up */

	if (obj->domain)

		omap_iommu_restore_tlb_entries(obj);



	ret = omap2_iommu_enable(obj);



	return ret;
@@ -1066,6 +1116,11 @@ static int omap_iommu_probe(struct platform_device *pdev) 


	obj->dev = &pdev->dev;

	obj->ctx = (void *)obj + sizeof(*obj);

	obj->cr_ctx = devm_kzalloc(&pdev->dev,

				   sizeof(*obj->cr_ctx) * obj->nr_tlb_entries,

				   GFP_KERNEL);

	if (!obj->cr_ctx)

		return -ENOMEM;



	spin_lock_init(&obj->iommu_lock);

	spin_lock_init(&obj->page_table_lock);

drivers/iommu/omap-iommu.h

+3 −0
Original line number Diff line number Diff line
@@ -73,6 +73,9 @@ struct omap_iommu { 


	void *ctx; /* iommu context: registres saved area */



	struct cr_regs *cr_ctx;

	u32 num_cr_ctx;



	int has_bus_err_back;

	u32 id;

CRA Git | Maintained and supported by SUSTech CRA and CCSE