Commit c3a5fd15 authored Dec 09, 2019 by Peng Fan Committed by Shawn Guo Dec 11, 2019

clk: imx: pll14xx: fix clk_pll14xx_wait_lock



The usage of readl_poll_timeout is wrong, the 3rd parameter(cond)
should be "val & LOCK_STATUS" not "val & LOCK_TIMEOUT_US",
It is not check whether the pll locked, LOCK_STATUS reflects the mask,
not LOCK_TIMEOUT_US.

Fixes: 8646d4dc ("clk: imx: Add PLLs driver for imx8mm soc")
Cc: <stable@vger.kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

parent ed11e317

drivers/clk/imx/clk-pll14xx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,7 @@ static int clk_pll14xx_wait_lock(struct clk_pll14xx *pll)
		{
		u32 val;

		return readl_poll_timeout(pll->base, val, val & LOCK_TIMEOUT_US, 0,
		return readl_poll_timeout(pll->base, val, val & LOCK_STATUS, 0,
		LOCK_TIMEOUT_US);
		}

Admin message