Commit c394f1ea authored Aug 07, 2006 by Stefan Richter

ieee1394: sbp2: enable auto spin-up for all SBP-2 devices

This is a follow-up to patch "ieee1394: sbp2: enable auto spin-up for
Maxtor disks". When I 'ejected' an OXUF922 based HDD from a Mac OS X
box, it was spun down by the Mac and did not spin up by itself when
attached to a Linux box right after that. The first SCSI command that
required the bridge to access the drive ended in
sda:<6>sd 18:0:0:0: Device not ready: <6>: Current: sense key: Not Ready
Additional sense: Logical unit not ready, initializing cmd. required

Therefore the flag which instructs scsi_mod to send START STOP UNIT with
START=1 ("make medium ready") after such a condition is now enabled
unconditionally for all FireWire storage devices.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

parent 87730d04

drivers/ieee1394/sbp2.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2515,6 +2515,7 @@ static int sbp2scsi_slave_alloc(struct scsi_device *sdev)
		(struct scsi_id_instance_data *)sdev->host->hostdata[0];

		scsi_id->sdev = sdev;
		sdev->allow_restart = 1;

		if (scsi_id->workarounds & SBP2_WORKAROUND_INQUIRY_36)
		sdev->inquiry_len = 36;
		@@ -2534,9 +2535,6 @@ static int sbp2scsi_slave_configure(struct scsi_device *sdev)
		sdev->skip_ms_page_8 = 1;
		if (scsi_id->workarounds & SBP2_WORKAROUND_FIX_CAPACITY)
		sdev->fix_capacity = 1;
		if (scsi_id->ne->guid_vendor_id == 0x0010b9 && /* Maxtor's OUI */
		(sdev->type == TYPE_DISK \|\| sdev->type == TYPE_RBC))
		sdev->allow_restart = 1;
		return 0;
		}

Admin message