Commit c393fbae authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/pci: Unexport drm_get_pci_dev 



Only user left is the shadow attach for legacy drivers.

v2: Shift the #ifdef CONFIG_DRM_LEGACY to now also include
drm_get_pci_dev() (Thomas)

Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Emil Velikov <emil.velikov@collabora.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225165835.2394442-1-daniel.vetter@ffwll.ch
parent 8ff1d62c

drivers/gpu/drm/drm_pci.c

+5 −21
Original line number Diff line number Diff line
@@ -75,7 +75,6 @@ drm_dma_handle_t *drm_pci_alloc(struct drm_device * dev, size_t size, size_t ali 


	return dmah;

}



EXPORT_SYMBOL(drm_pci_alloc);



/**
@@ -191,22 +190,10 @@ void drm_pci_agp_destroy(struct drm_device *dev) 
	}

}



/**

 * drm_get_pci_dev - Register a PCI device with the DRM subsystem

 * @pdev: PCI device

 * @ent: entry from the PCI ID table that matches @pdev

 * @driver: DRM device driver

 *

 * Attempt to gets inter module "drm" information. If we are first

 * then register the character device and inter module information.

 * Try and register, if we fail to register, backout previous work.

 *

 * NOTE: This function is deprecated, please use drm_dev_alloc() and

 * drm_dev_register() instead and remove your &drm_driver.load callback.

 *

 * Return: 0 on success or a negative error code on failure.

 */

int drm_get_pci_dev(struct pci_dev *pdev, const struct pci_device_id *ent,

#ifdef CONFIG_DRM_LEGACY



static int drm_get_pci_dev(struct pci_dev *pdev,

			   const struct pci_device_id *ent,

			   struct drm_driver *driver)

{

	struct drm_device *dev;
@@ -250,9 +237,6 @@ err_free: 
	drm_dev_put(dev);

	return ret;

}

EXPORT_SYMBOL(drm_get_pci_dev);



#ifdef CONFIG_DRM_LEGACY



/**

 * drm_legacy_pci_init - shadow-attach a legacy DRM PCI driver

include/drm/drm_pci.h

+0 −11
Original line number Diff line number Diff line
@@ -45,10 +45,6 @@ struct drm_dma_handle *drm_pci_alloc(struct drm_device *dev, size_t size, 
				     size_t align);

void drm_pci_free(struct drm_device *dev, struct drm_dma_handle * dmah);



int drm_get_pci_dev(struct pci_dev *pdev,

		    const struct pci_device_id *ent,

		    struct drm_driver *driver);



#else



static inline struct drm_dma_handle *drm_pci_alloc(struct drm_device *dev,
@@ -62,13 +58,6 @@ static inline void drm_pci_free(struct drm_device *dev, 
{

}



static inline int drm_get_pci_dev(struct pci_dev *pdev,

				  const struct pci_device_id *ent,

				  struct drm_driver *driver)

{

	return -ENOSYS;

}



#endif



#endif /* _DRM_PCI_H_ */

CRA Git | Maintained and supported by SUSTech CRA and CCSE