Commit c38e7e21 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

firewire: ohci: Replace zero-length array with flexible-array 

There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://github.com/KSPP/linux/issues/21



Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
parent 6b5679d2

drivers/firewire/core-cdev.c

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ struct inbound_transaction_resource { 
struct descriptor_resource {

	struct client_resource resource;

	struct fw_descriptor descriptor;

	u32 data[0];

	u32 data[];

};



struct iso_resource {

drivers/firewire/core-transaction.c

+1 −1
Original line number Diff line number Diff line
@@ -620,7 +620,7 @@ struct fw_request { 
	u32 request_header[4];

	int ack;

	u32 length;

	u32 data[0];

	u32 data[];

};



static void free_response_callback(struct fw_packet *packet,

drivers/firewire/core.h

+1 −1
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ struct fw_node { 
	/* Upper layer specific data. */

	void *data;



	struct fw_node *ports[0];

	struct fw_node *ports[];

};



static inline struct fw_node *fw_node_get(struct fw_node *node)

drivers/firewire/nosy.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ struct pcl { 


struct packet {

	unsigned int length;

	char data[0];

	char data[];

};



struct packet_buffer {

drivers/firewire/ohci.c

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ struct descriptor_buffer { 
	dma_addr_t buffer_bus;

	size_t buffer_size;

	size_t used;

	struct descriptor buffer[0];

	struct descriptor buffer[];

};



struct context {

CRA Git | Maintained and supported by SUSTech CRA and CCSE