Commit c3676d5c authored May 01, 2014 by Mark Brown

spi: core: Don't destroy master queue if we fail to create it

If we fail to create the master queue for some reason we should not attempt
to clean it up since attempting to stop a kthread that was not created will
hang and it's just generally bad practice. Unfortunately at present we call
spi_destroy_queue() even in cases where the creation fails.

Fix this by fixing the error handling in spi_master_initialize_queue() so
that we only flag the master as queued or destroy the queue if creation
succeeded. The change to the flag is done since the general master
cleanup uses this to destroy the queue.

Reported-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

parent 2de440f5

drivers/spi/spi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1172,7 +1172,6 @@ static int spi_master_initialize_queue(struct spi_master *master)
		{
		int ret;

		master->queued = true;
		master->transfer = spi_queued_transfer;
		if (!master->transfer_one_message)
		master->transfer_one_message = spi_transfer_one_message;
		@@ -1183,6 +1182,7 @@ static int spi_master_initialize_queue(struct spi_master *master)
		dev_err(&master->dev, "problem initializing queue\n");
		goto err_init_queue;
		}
		master->queued = true;
		ret = spi_start_queue(master);
		if (ret) {
		dev_err(&master->dev, "problem starting queue\n");
		@@ -1192,8 +1192,8 @@ static int spi_master_initialize_queue(struct spi_master *master)
		return 0;

		err_start_queue:
		err_init_queue:
		spi_destroy_queue(master);
		err_init_queue:
		return ret;
		}

Admin message