Commit c33fdc34 authored Nov 11, 2019 by Colin Ian King Committed by David S. Miller Nov 11, 2019

tipc: fix update of the uninitialized variable err



Variable err is not uninitialized and hence can potentially contain
any garbage value.  This may cause an error when logical or'ing the
return values from the calls to functions crypto_aead_setauthsize or
crypto_aead_setkey.  Fix this by setting err to the return of
crypto_aead_setauthsize rather than or'ing in the return into the
uninitialized variable

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: fc1b6d6d ("tipc: introduce TIPC encryption & authentication")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 59618bc0

net/tipc/crypto.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -463,7 +463,7 @@ static int tipc_aead_init(struct tipc_aead *aead, struct tipc_aead_key ukey,
		break;
		}

		err \|= crypto_aead_setauthsize(tfm, TIPC_AES_GCM_TAG_SIZE);
		err = crypto_aead_setauthsize(tfm, TIPC_AES_GCM_TAG_SIZE);
		err \|= crypto_aead_setkey(tfm, ukey->key, keylen);
		if (unlikely(err)) {
		crypto_free_aead(tfm);

Admin message