crypto: caam/qi2 - remove redundant assignment to ret (c31b4ade) · Commits · 戴 / test

The variable ret is being assigned a value that is never read, the error exit path via label 'unmap' returns -ENOMEM anyhow, so assigning ret with -ENOMEM is redundamt. Addresses-Coverity: ("Unused value") Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

drivers/crypto/caam/caamalg_qi2.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -4044,7 +4044,6 @@ static int ahash_finup_no_ctx(struct ahash_request *req)
		DMA_TO_DEVICE);
		if (dma_mapping_error(ctx->dev, edesc->qm_sg_dma)) {
		dev_err(ctx->dev, "unable to map S/G table\n");
		ret = -ENOMEM;
		goto unmap;
		}
		edesc->qm_sg_bytes = qm_sg_bytes;
		@@ -4055,7 +4054,6 @@ static int ahash_finup_no_ctx(struct ahash_request *req)
		if (dma_mapping_error(ctx->dev, state->ctx_dma)) {
		dev_err(ctx->dev, "unable to map ctx\n");
		state->ctx_dma = 0;
		ret = -ENOMEM;
		goto unmap;
		}

Admin message