Commit c30fe541 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Mark non-global functions and variables as static 



Each of rcu_state, rcu_rnp_online_cpus(), rcu_dynticks_curr_cpu_in_eqs(),
and rcu_dynticks_snap() are used only in the kernel/rcu/tree.o translation
unit, and may thus be marked static.  This commit therefore makes this
change.

Reported-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Reviewed-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
parent 4414abf8

kernel/rcu/tree.c

+4 −4
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(struct rcu_data, rcu_data) = { 
	.dynticks_nmi_nesting = DYNTICK_IRQ_NONIDLE,

	.dynticks = ATOMIC_INIT(RCU_DYNTICK_CTRL_CTR),

};

struct rcu_state rcu_state = {

static struct rcu_state rcu_state = {

	.level = { &rcu_state.node[0] },

	.gp_state = RCU_GP_IDLE,

	.gp_seq = (0UL - 300UL) << RCU_SEQ_CTR_SHIFT,
@@ -188,7 +188,7 @@ EXPORT_SYMBOL_GPL(rcu_get_gp_kthreads_prio); 
 * held, but the bit corresponding to the current CPU will be stable

 * in most contexts.

 */

unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp)

static unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp)

{

	return READ_ONCE(rnp->qsmaskinitnext);

}
@@ -294,7 +294,7 @@ static void rcu_dynticks_eqs_online(void) 
 *

 * No ordering, as we are sampling CPU-local information.

 */

bool rcu_dynticks_curr_cpu_in_eqs(void)

static bool rcu_dynticks_curr_cpu_in_eqs(void)

{

	struct rcu_data *rdp = this_cpu_ptr(&rcu_data);
@@ -305,7 +305,7 @@ bool rcu_dynticks_curr_cpu_in_eqs(void) 
 * Snapshot the ->dynticks counter with full ordering so as to allow

 * stable comparison of this counter with past and future snapshots.

 */

int rcu_dynticks_snap(struct rcu_data *rdp)

static int rcu_dynticks_snap(struct rcu_data *rdp)

{

	int snap = atomic_add_return(0, &rdp->dynticks);

kernel/rcu/tree.h

+0 −2
Original line number Diff line number Diff line
@@ -403,8 +403,6 @@ static const char *tp_rcu_varname __used __tracepoint_string = rcu_name; 
#define RCU_NAME rcu_name

#endif /* #else #ifdef CONFIG_TRACING */



int rcu_dynticks_snap(struct rcu_data *rdp);



/* Forward declarations for tree_plugin.h */

static void rcu_bootup_announce(void);

static void rcu_qs(void);

CRA Git | Maintained and supported by SUSTech CRA and CCSE