Commit c30c2f99 authored by Catalin Marinas's avatar Catalin Marinas
Browse files

ARMv7: Add extra barriers for flush_cache_all compressed/head.S 



The flush_cache_all function on ARMv7 is implemented as a series of
cache operations by set/way. These are not guaranteed to be ordered with
previous memory accesses, requiring a DMB. This patch also adds barriers
for the TLB operations in compressed/head.S

Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 2bedbdf4

arch/arm/boot/compressed/head.S

+10 −4
Original line number Diff line number Diff line
@@ -717,6 +717,9 @@ __armv7_mmu_cache_off: 
		bl	__armv7_mmu_cache_flush

		mov	r0, #0

		mcr	p15, 0, r0, c8, c7, 0	@ invalidate whole TLB

		mcr	p15, 0, r0, c7, c5, 6	@ invalidate BTC

		mcr	p15, 0, r0, c7, c10, 4	@ DSB

		mcr	p15, 0, r0, c7, c5, 4	@ ISB

		mov	pc, r12



__arm6_mmu_cache_off:
@@ -778,12 +781,13 @@ __armv6_mmu_cache_flush: 
__armv7_mmu_cache_flush:

		mrc	p15, 0, r10, c0, c1, 5	@ read ID_MMFR1

		tst	r10, #0xf << 16		@ hierarchical cache (ARMv7)

		beq	hierarchical

		mov	r10, #0

		beq	hierarchical

		mcr	p15, 0, r10, c7, c14, 0	@ clean+invalidate D

		b	iflush

hierarchical:

		stmfd	sp!, {r0-r5, r7, r9-r11}

		mcr	p15, 0, r10, c7, c10, 5	@ DMB

		stmfd	sp!, {r0-r5, r7, r9, r11}

		mrc	p15, 1, r0, c0, c0, 1	@ read clidr

		ands	r3, r0, #0x7000000	@ extract loc from clidr

		mov	r3, r3, lsr #23		@ left align loc bit field
@@ -820,12 +824,14 @@ skip: 
		cmp	r3, r10

		bgt	loop1

finished:

		ldmfd	sp!, {r0-r5, r7, r9, r11}

		mov	r10, #0			@ swith back to cache level 0

		mcr	p15, 2, r10, c0, c0, 0	@ select current cache level in cssr

		ldmfd	sp!, {r0-r5, r7, r9-r11}

iflush:

		mcr	p15, 0, r10, c7, c10, 4	@ DSB

		mcr	p15, 0, r10, c7, c5, 0	@ invalidate I+BTB

		mcr	p15, 0, r10, c7, c10, 4	@ drain WB

		mcr	p15, 0, r10, c7, c10, 4	@ DSB

		mcr	p15, 0, r10, c7, c5, 4	@ ISB

		mov	pc, lr



__armv5tej_mmu_cache_flush:

arch/arm/mm/cache-v7.S

+2 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 
 *	- mm    - mm_struct describing address space

 */

ENTRY(v7_flush_dcache_all)

	dmb					@ ensure ordering with previous memory accesses

	mrc	p15, 1, r0, c0, c0, 1		@ read clidr

	ands	r3, r0, #0x7000000		@ extract loc from clidr

	mov	r3, r3, lsr #23			@ left align loc bit field
@@ -64,6 +65,7 @@ skip: 
finished:

	mov	r10, #0				@ swith back to cache level 0

	mcr	p15, 2, r10, c0, c0, 0		@ select current cache level in cssr

	dsb

	isb

	mov	pc, lr

ENDPROC(v7_flush_dcache_all)

CRA Git | Maintained and supported by SUSTech CRA and CCSE