Commit c2e77a18 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: dsa: b53: Fix ARL register definitions 



The ARL {MAC,VID} tuple and the forward entry were off by 0x10 bytes,
which means that when we read/wrote from/to ARL bin index 0, we were
actually accessing the ARLA_RWCTRL register.

Fixes: 1da6df85 ("net: dsa: b53: Implement ARL add/del/dump operations")
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eab167f4

drivers/net/dsa/b53/b53_regs.h

+2 −2
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ 
 *

 * BCM5325 and BCM5365 share most definitions below

 */

#define B53_ARLTBL_MAC_VID_ENTRY(n)	(0x10 * (n))

#define B53_ARLTBL_MAC_VID_ENTRY(n)	((0x10 * (n)) + 0x10)

#define   ARLTBL_MAC_MASK		0xffffffffffffULL

#define   ARLTBL_VID_S			48

#define   ARLTBL_VID_MASK_25		0xff
@@ -316,7 +316,7 @@ 
#define   ARLTBL_VALID_25		BIT(63)



/* ARL Table Data Entry N Registers (32 bit) */

#define B53_ARLTBL_DATA_ENTRY(n)	((0x10 * (n)) + 0x08)

#define B53_ARLTBL_DATA_ENTRY(n)	((0x10 * (n)) + 0x18)

#define   ARLTBL_DATA_PORT_ID_MASK	0x1ff

#define   ARLTBL_TC(tc)			((3 & tc) << 11)

#define   ARLTBL_AGE			BIT(14)

CRA Git | Maintained and supported by SUSTech CRA and CCSE