Commit c2d3f25d authored Oct 09, 2013 by Ralf Baechle Committed by Oleg Nesterov Oct 29, 2013

uprobes: Remove the wrong __weak attribute

linux/uprobes.h declares arch_uprobe_skip_sstep() as a weak function.
But as there is no definition of generic version so when trying to build
uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep()
implementation, the vmlinux will try to call arch_uprobe_skip_sstep()
somehwere in Stupidhistan leading to a system crash. We rather want a
proper link error so remove arch_uprobe_skip_sstep().

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>

parent 5a3126d4

include/linux/uprobes.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -123,7 +123,7 @@ extern int uprobe_post_sstep_notifier(struct pt_regs *regs);
		extern int uprobe_pre_sstep_notifier(struct pt_regs *regs);
		extern void uprobe_notify_resume(struct pt_regs *regs);
		extern bool uprobe_deny_signal(void);
		extern bool __weak arch_uprobe_skip_sstep(struct arch_uprobe aup, struct pt_regs regs);
		extern bool arch_uprobe_skip_sstep(struct arch_uprobe aup, struct pt_regs regs);
		extern void uprobe_clear_state(struct mm_struct *mm);
		#else /* !CONFIG_UPROBES */
		struct uprobes_state {

Admin message