Commit c2cf52eb authored by Simon Kirby's avatar Simon Kirby Committed by Josef Bacik
Browse files

Btrfs: Include the device in most error printk()s 



With more than one btrfs volume mounted, it can be very difficult to find
out which volume is hitting an error. btrfs_error() will print this, but
it is currently rigged as more of a fatal error handler, while many of
the printk()s are currently for debugging and yet-unhandled cases.

This patch just changes the functions where the device information is
already available. Some cases remain where the root or fs_info is not
passed to the function emitting the error.

This may introduce some confusion with volumes backed by multiple devices
emitting errors referring to the primary device in the set instead of the
one on which the error occurred.

Use btrfs_printk(fs_info, format, ...) rather than writing the device
string every time, and introduce macro wrappers ala XFS for brevity.
Since the function already cannot be used for continuations, print a
newline as part of the btrfs_printk() message rather than at each caller.

Signed-off-by: default avatarSimon Kirby <sim@hostway.ca>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.cz>
Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
parent aa825914

fs/btrfs/ctree.h

+19 −2
Original line number Diff line number Diff line
@@ -3643,14 +3643,31 @@ int btrfs_sync_fs(struct super_block *sb, int wait); 


#ifdef CONFIG_PRINTK

__printf(2, 3)

void btrfs_printk(struct btrfs_fs_info *fs_info, const char *fmt, ...);

void btrfs_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...);

#else

static inline __printf(2, 3)

void btrfs_printk(struct btrfs_fs_info *fs_info, const char *fmt, ...)

void btrfs_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...)

{

}

#endif



#define btrfs_emerg(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_EMERG fmt, ##args)

#define btrfs_alert(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_ALERT fmt, ##args)

#define btrfs_crit(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_CRIT fmt, ##args)

#define btrfs_err(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_ERR fmt, ##args)

#define btrfs_warn(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_WARNING fmt, ##args)

#define btrfs_notice(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_NOTICE fmt, ##args)

#define btrfs_info(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_INFO fmt, ##args)

#define btrfs_debug(fs_info, fmt, args...) \

	btrfs_printk(fs_info, KERN_DEBUG fmt, ##args)



__printf(5, 6)

void __btrfs_std_error(struct btrfs_fs_info *fs_info, const char *function,

		     unsigned int line, int errno, const char *fmt, ...);

fs/btrfs/extent-tree.c

+33 −34
Original line number Diff line number Diff line
@@ -2403,9 +2403,7 @@ static noinline int run_clustered_refs(struct btrfs_trans_handle *trans, 
				btrfs_free_delayed_extent_op(extent_op);



				if (ret) {

					printk(KERN_DEBUG

					       "btrfs: run_delayed_extent_op "

					       "returned %d\n", ret);

					btrfs_debug(fs_info, "run_delayed_extent_op returned %d", ret);

					spin_lock(&delayed_refs->lock);

					btrfs_delayed_ref_unlock(locked_ref);

					return ret;
@@ -2444,8 +2442,7 @@ static noinline int run_clustered_refs(struct btrfs_trans_handle *trans, 
		if (ret) {

			btrfs_delayed_ref_unlock(locked_ref);

			btrfs_put_delayed_ref(ref);

			printk(KERN_DEBUG

			       "btrfs: run_one_delayed_ref returned %d\n", ret);

			btrfs_debug(fs_info, "run_one_delayed_ref returned %d", ret);

			spin_lock(&delayed_refs->lock);

			return ret;

		}
@@ -2522,7 +2519,8 @@ int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans, 
	if (list_empty(&trans->qgroup_ref_list) !=

	    !trans->delayed_ref_elem.seq) {

		/* list without seq or seq without list */

		printk(KERN_ERR "btrfs: qgroup accounting update error, list is%s empty, seq is %llu\n",

		btrfs_err(fs_info,

			"qgroup accounting update error, list is%s empty, seq is %llu",

			list_empty(&trans->qgroup_ref_list) ? "" : " not",

			trans->delayed_ref_elem.seq);

		BUG();
@@ -3723,7 +3721,7 @@ static void check_system_chunk(struct btrfs_trans_handle *trans, 


	thresh = get_system_chunk_thresh(root, type);

	if (left < thresh && btrfs_test_opt(root, ENOSPC_DEBUG)) {

		printk(KERN_INFO "left=%llu, need=%llu, flags=%llu\n",

		btrfs_info(root->fs_info, "left=%llu, need=%llu, flags=%llu",

			left, thresh, type);

		dump_space_info(info, 0, 0);

	}
@@ -5501,9 +5499,8 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans, 
			}



			if (ret) {

				printk(KERN_ERR "umm, got %d back from search"

				       ", was looking for %llu\n", ret,

				       (unsigned long long)bytenr);

				btrfs_err(info, "umm, got %d back from search, was looking for %llu",

					ret, (unsigned long long)bytenr);

				if (ret > 0)

					btrfs_print_leaf(extent_root,

							 path->nodes[0]);
@@ -5517,8 +5514,8 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans, 
	} else if (ret == -ENOENT) {

		btrfs_print_leaf(extent_root, path->nodes[0]);

		WARN_ON(1);

		printk(KERN_ERR "btrfs unable to find ref byte nr %llu "

		       "parent %llu root %llu  owner %llu offset %llu\n",

		btrfs_err(info,

			"unable to find ref byte nr %llu parent %llu root %llu  owner %llu offset %llu",

			(unsigned long long)bytenr,

			(unsigned long long)parent,

			(unsigned long long)root_objectid,
@@ -5551,9 +5548,8 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans, 
		ret = btrfs_search_slot(trans, extent_root, &key, path,

					-1, 1);

		if (ret) {

			printk(KERN_ERR "umm, got %d back from search"

			       ", was looking for %llu\n", ret,

			       (unsigned long long)bytenr);

			btrfs_err(info, "umm, got %d back from search, was looking for %llu",

				ret, (unsigned long long)bytenr);

			btrfs_print_leaf(extent_root, path->nodes[0]);

		}

		if (ret < 0) {
@@ -5922,7 +5918,7 @@ static noinline int find_free_extent(struct btrfs_trans_handle *trans, 


	space_info = __find_space_info(root->fs_info, data);

	if (!space_info) {

		printk(KERN_ERR "No space info for %llu\n", data);

		btrfs_err(root->fs_info, "No space info for %llu", data);

		return -ENOSPC;

	}
@@ -6346,8 +6342,8 @@ again: 
			struct btrfs_space_info *sinfo;



			sinfo = __find_space_info(root->fs_info, data);

			printk(KERN_ERR "btrfs allocation failed flags %llu, "

			       "wanted %llu\n", (unsigned long long)data,

			btrfs_err(root->fs_info, "allocation failed flags %llu, wanted %llu",

				(unsigned long long)data,

				(unsigned long long)num_bytes);

			if (sinfo)

				dump_space_info(sinfo, num_bytes, 1);
@@ -6367,7 +6363,7 @@ static int __btrfs_free_reserved_extent(struct btrfs_root *root, 


	cache = btrfs_lookup_block_group(root->fs_info, start);

	if (!cache) {

		printk(KERN_ERR "Unable to find block group for %llu\n",

		btrfs_err(root->fs_info, "Unable to find block group for %llu",

			(unsigned long long)start);

		return -ENOSPC;

	}
@@ -6463,8 +6459,8 @@ static int alloc_reserved_file_extent(struct btrfs_trans_handle *trans, 


	ret = update_block_group(root, ins->objectid, ins->offset, 1);

	if (ret) { /* -ENOENT, logic error */

		printk(KERN_ERR "btrfs update block group failed for %llu "

		       "%llu\n", (unsigned long long)ins->objectid,

		btrfs_err(fs_info, "update block group failed for %llu %llu",

			(unsigned long long)ins->objectid,

			(unsigned long long)ins->offset);

		BUG();

	}
@@ -6536,8 +6532,8 @@ static int alloc_reserved_tree_block(struct btrfs_trans_handle *trans, 


	ret = update_block_group(root, ins->objectid, root->leafsize, 1);

	if (ret) { /* -ENOENT, logic error */

		printk(KERN_ERR "btrfs update block group failed for %llu "

		       "%llu\n", (unsigned long long)ins->objectid,

		btrfs_err(fs_info, "update block group failed for %llu %llu",

			(unsigned long long)ins->objectid,

			(unsigned long long)ins->offset);

		BUG();

	}
@@ -7027,7 +7023,10 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, 
		return ret;

	}



	BUG_ON(wc->refs[level - 1] == 0);

	if (unlikely(wc->refs[level - 1] == 0)) {

		btrfs_err(root->fs_info, "Missing references.");

		BUG();

	}

	*lookup_info = 0;



	if (wc->stage == DROP_REFERENCE) {

fs/btrfs/free-space-cache.c

+24 −19
Original line number Diff line number Diff line
@@ -104,7 +104,8 @@ struct inode *lookup_free_space_inode(struct btrfs_root *root, 


	spin_lock(&block_group->lock);

	if (!((BTRFS_I(inode)->flags & flags) == flags)) {

		printk(KERN_INFO "Old style space inode found, converting.\n");

		btrfs_info(root->fs_info,

			"Old style space inode found, converting.");

		BTRFS_I(inode)->flags |= BTRFS_INODE_NODATASUM |

			BTRFS_INODE_NODATACOW;

		block_group->disk_cache_state = BTRFS_DC_CLEAR;
@@ -669,8 +670,9 @@ int __load_free_space_cache(struct btrfs_root *root, struct inode *inode, 
	btrfs_release_path(path);



	if (BTRFS_I(inode)->generation != generation) {

		printk(KERN_ERR "btrfs: free space inode generation (%llu) did"

		       " not match free space cache generation (%llu)\n",

		btrfs_err(root->fs_info,

			"free space inode generation (%llu) "

			"did not match free space cache generation (%llu)",

			(unsigned long long)BTRFS_I(inode)->generation,

			(unsigned long long)generation);

		return 0;
@@ -721,8 +723,8 @@ int __load_free_space_cache(struct btrfs_root *root, struct inode *inode, 
			ret = link_free_space(ctl, e);

			spin_unlock(&ctl->tree_lock);

			if (ret) {

				printk(KERN_ERR "Duplicate entries in "

				       "free space cache, dumping\n");

				btrfs_err(root->fs_info,

					"Duplicate entries in free space cache, dumping");

				kmem_cache_free(btrfs_free_space_cachep, e);

				goto free_cache;

			}
@@ -741,8 +743,8 @@ int __load_free_space_cache(struct btrfs_root *root, struct inode *inode, 
			ctl->op->recalc_thresholds(ctl);

			spin_unlock(&ctl->tree_lock);

			if (ret) {

				printk(KERN_ERR "Duplicate entries in "

				       "free space cache, dumping\n");

				btrfs_err(root->fs_info,

					"Duplicate entries in free space cache, dumping");

				kmem_cache_free(btrfs_free_space_cachep, e);

				goto free_cache;

			}
@@ -833,8 +835,8 @@ int load_free_space_cache(struct btrfs_fs_info *fs_info, 


	if (!matched) {

		__btrfs_remove_free_space_cache(ctl);

		printk(KERN_ERR "block group %llu has an wrong amount of free "

		       "space\n", block_group->key.objectid);

		btrfs_err(fs_info, "block group %llu has wrong amount of free space",

			block_group->key.objectid);

		ret = -1;

	}

out:
@@ -845,8 +847,8 @@ out: 
		spin_unlock(&block_group->lock);

		ret = 0;



		printk(KERN_ERR "btrfs: failed to load free space cache "

		       "for block group %llu\n", block_group->key.objectid);

		btrfs_err(fs_info, "failed to load free space cache for block group %llu",

			block_group->key.objectid);

	}



	iput(inode);
@@ -1104,8 +1106,9 @@ int btrfs_write_out_cache(struct btrfs_root *root, 
		spin_unlock(&block_group->lock);

		ret = 0;

#ifdef DEBUG

		printk(KERN_ERR "btrfs: failed to write free space cache "

		       "for block group %llu\n", block_group->key.objectid);

		btrfs_err(root->fs_info,

			"failed to write free space cache for block group %llu",

			block_group->key.objectid);

#endif

	}
@@ -2931,8 +2934,9 @@ int load_free_ino_cache(struct btrfs_fs_info *fs_info, struct btrfs_root *root) 
	ret = __load_free_space_cache(root, inode, ctl, path, 0);



	if (ret < 0)

		printk(KERN_ERR "btrfs: failed to load free ino cache for "

		       "root %llu\n", root->root_key.objectid);

		btrfs_err(fs_info,

			"failed to load free ino cache for root %llu",

			root->root_key.objectid);

out_put:

	iput(inode);

out:
@@ -2959,8 +2963,9 @@ int btrfs_write_out_ino_cache(struct btrfs_root *root, 
	if (ret) {

		btrfs_delalloc_release_metadata(inode, inode->i_size);

#ifdef DEBUG

		printk(KERN_ERR "btrfs: failed to write free ino cache "

		       "for root %llu\n", root->root_key.objectid);

		btrfs_err(root->fs_info,

			"failed to write free ino cache for root %llu",

			root->root_key.objectid);

#endif

	}

fs/btrfs/inode.c

+37 −33
Original line number Diff line number Diff line
@@ -2793,6 +2793,8 @@ static int btrfs_readpage_end_io_hook(struct page *page, u64 start, u64 end, 
	int ret;

	struct btrfs_root *root = BTRFS_I(inode)->root;

	u32 csum = ~(u32)0;

	static DEFINE_RATELIMIT_STATE(_rs, DEFAULT_RATELIMIT_INTERVAL,

	                              DEFAULT_RATELIMIT_BURST);



	if (PageChecked(page)) {

		ClearPageChecked(page);
@@ -2829,8 +2831,8 @@ good: 
	return 0;



zeroit:

	printk_ratelimited(KERN_INFO "btrfs csum failed ino %llu off %llu csum %u "

		       "private %llu\n",

	if (__ratelimit(&_rs))

		btrfs_info(root->fs_info, "csum failed ino %llu off %llu csum %u private %llu",

			(unsigned long long)btrfs_ino(page->mapping->host),

			(unsigned long long)start, csum,

			(unsigned long long)private);
@@ -3114,8 +3116,8 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) 
		 */



		if (found_key.offset == last_objectid) {

			printk(KERN_ERR "btrfs: Error removing orphan entry, "

			       "stopping orphan cleanup\n");

			btrfs_err(root->fs_info,

				"Error removing orphan entry, stopping orphan cleanup");

			ret = -EINVAL;

			goto out;

		}
@@ -3172,7 +3174,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) 
				ret = PTR_ERR(trans);

				goto out;

			}

			printk(KERN_ERR "auto deleting %Lu\n",

			btrfs_debug(root->fs_info, "auto deleting %Lu",

				found_key.objectid);

			ret = btrfs_del_orphan_item(trans, root,

						    found_key.objectid);
@@ -3237,13 +3239,14 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) 
	}



	if (nr_unlink)

		printk(KERN_INFO "btrfs: unlinked %d orphans\n", nr_unlink);

		btrfs_info(root->fs_info, "unlinked %d orphans", nr_unlink);

	if (nr_truncate)

		printk(KERN_INFO "btrfs: truncated %d orphans\n", nr_truncate);

		btrfs_info(root->fs_info, "truncated %d orphans", nr_truncate);



out:

	if (ret)

		printk(KERN_CRIT "btrfs: could not do orphan cleanup %d\n", ret);

		btrfs_crit(root->fs_info,

			"could not do orphan cleanup %d", ret);

	btrfs_free_path(path);

	return ret;

}
@@ -3591,8 +3594,9 @@ static int __btrfs_unlink_inode(struct btrfs_trans_handle *trans, 
	ret = btrfs_del_inode_ref(trans, root, name, name_len, ino,

				  dir_ino, &index);

	if (ret) {

		printk(KERN_INFO "btrfs failed to delete reference to %.*s, "

		       "inode %llu parent %llu\n", name_len, name,

		btrfs_info(root->fs_info,

			"failed to delete reference to %.*s, inode %llu parent %llu",

			name_len, name,

			(unsigned long long)ino, (unsigned long long)dir_ino);

		btrfs_abort_transaction(trans, root, ret);

		goto err;
@@ -4670,8 +4674,9 @@ void btrfs_evict_inode(struct inode *inode) 
			ret = btrfs_block_rsv_migrate(global_rsv, rsv, min_size);



		if (ret) {

			printk(KERN_WARNING "Could not get space for a "

			       "delete, will truncate on mount %d\n", ret);

			btrfs_warn(root->fs_info,

				"Could not get space for a delete, will truncate on mount %d",

				ret);

			btrfs_orphan_del(NULL, inode);

			btrfs_free_block_rsv(root, rsv);

			goto no_delete;
@@ -6259,8 +6264,8 @@ not_found_em: 
insert:

	btrfs_release_path(path);

	if (em->start > start || extent_map_end(em) <= start) {

		printk(KERN_ERR "Btrfs: bad extent! em: [%llu %llu] passed "

		       "[%llu %llu]\n", (unsigned long long)em->start,

		btrfs_err(root->fs_info, "bad extent! em: [%llu %llu] passed [%llu %llu]",

			(unsigned long long)em->start,

			(unsigned long long)em->len,

			(unsigned long long)start,

			(unsigned long long)len);
@@ -6919,6 +6924,7 @@ static void btrfs_endio_direct_read(struct bio *bio, int err) 
	struct bio_vec *bvec_end = bio->bi_io_vec + bio->bi_vcnt - 1;

	struct bio_vec *bvec = bio->bi_io_vec;

	struct inode *inode = dip->inode;

	struct btrfs_root *root = BTRFS_I(inode)->root;

	u64 start;



	start = dip->logical_offset;
@@ -6944,8 +6950,7 @@ static void btrfs_endio_direct_read(struct bio *bio, int err) 
			flush_dcache_page(bvec->bv_page);

			if (csum != private) {

failed:

				printk(KERN_ERR "btrfs csum failed ino %llu off"

				      " %llu csum %u private %u\n",

				btrfs_err(root->fs_info, "csum failed ino %llu off %llu csum %u private %u",

					(unsigned long long)btrfs_ino(inode),

					(unsigned long long)start,

					csum, (unsigned)private);
@@ -7940,7 +7945,7 @@ void btrfs_destroy_inode(struct inode *inode) 


	if (test_bit(BTRFS_INODE_HAS_ORPHAN_ITEM,

		     &BTRFS_I(inode)->runtime_flags)) {

		printk(KERN_INFO "BTRFS: inode %llu still on the orphan list\n",

		btrfs_info(root->fs_info, "inode %llu still on the orphan list",

			(unsigned long long)btrfs_ino(inode));

		atomic_dec(&root->orphan_inodes);

	}
@@ -7950,8 +7955,7 @@ void btrfs_destroy_inode(struct inode *inode) 
		if (!ordered)

			break;

		else {

			printk(KERN_ERR "btrfs found ordered "

			       "extent %llu %llu on inode cleanup\n",

			btrfs_err(root->fs_info, "found ordered extent %llu %llu on inode cleanup",

				(unsigned long long)ordered->file_offset,

				(unsigned long long)ordered->len);

			btrfs_remove_ordered_extent(inode, ordered);

fs/btrfs/print-tree.c

+4 −5
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *l) 


	nr = btrfs_header_nritems(l);



	printk(KERN_INFO "leaf %llu total ptrs %d free space %d\n",

	btrfs_info(root->fs_info, "leaf %llu total ptrs %d free space %d",

		(unsigned long long)btrfs_header_bytenr(l), nr,

		btrfs_leaf_free_space(root, l));

	for (i = 0 ; i < nr ; i++) {
@@ -319,10 +319,9 @@ void btrfs_print_tree(struct btrfs_root *root, struct extent_buffer *c) 
		btrfs_print_leaf(root, c);

		return;

	}

	printk(KERN_INFO "node %llu level %d total ptrs %d free spc %u\n",

	btrfs_info(root->fs_info, "node %llu level %d total ptrs %d free spc %u",

		(unsigned long long)btrfs_header_bytenr(c),

	      level, nr,

	       (u32)BTRFS_NODEPTRS_PER_BLOCK(root) - nr);

		level, nr, (u32)BTRFS_NODEPTRS_PER_BLOCK(root) - nr);

	for (i = 0; i < nr; i++) {

		btrfs_node_key_to_cpu(c, &key, i);

		printk(KERN_INFO "\tkey %d (%llu %u %llu) block %llu\n",

CRA Git | Maintained and supported by SUSTech CRA and CCSE