Commit c2cac2f7 authored Nov 30, 2016 by Mohammed Shafi Shajakhan Committed by Kalle Valo Dec 01, 2016

ath10k: fix soft lockup during firmware crash/hw-restart



During firmware crash (or) user requested manual restart
the system gets into a soft lock up state because of the
below root cause.

During user requested hardware restart / firmware crash
the system goes into a soft lockup state as 'napi_synchronize'
is called after 'napi_disable' (which sets 'NAPI_STATE_SCHED'
bit) and it sleeps into infinite loop as it waits for
'NAPI_STATE_SCHED' to be cleared. This condition is hit because
'ath10k_hif_stop' is called twice as below (resulting in calling
'napi_synchronize' after 'napi_disable')

'ath10k_core_restart' -> 'ath10k_hif_stop' (ATH10K_STATE_ON) ->
-> 'ieee80211_restart_hw' -> 'ath10k_start' -> 'ath10k_halt' ->
'ath10k_core_stop' -> 'ath10k_hif_stop' (ATH10K_STATE_RESTARTING)

Fix this by calling 'ath10k_halt' in ath10k_core_restart itself
as it makes more sense before informing mac80211 to restart h/w
Also remove 'ath10k_halt' in ath10k_start for the state of 'restarting'

Fixes: 3c97f5de ("ath10k: implement NAPI support")
Cc: <stable@vger.kernel.org> # v4.9
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 4e322f7d

drivers/net/wireless/ath/ath10k/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1537,7 +1537,7 @@ static void ath10k_core_restart(struct work_struct *work)
		switch (ar->state) {
		case ATH10K_STATE_ON:
		ar->state = ATH10K_STATE_RESTARTING;
		ath10k_hif_stop(ar);
		ath10k_halt(ar);
		ath10k_scan_finish(ar);
		ieee80211_restart_hw(ar->hw);
		break;

drivers/net/wireless/ath/ath10k/mac.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -4451,7 +4451,6 @@ static int ath10k_start(struct ieee80211_hw *hw)
		ar->state = ATH10K_STATE_ON;
		break;
		case ATH10K_STATE_RESTARTING:
		ath10k_halt(ar);
		ar->state = ATH10K_STATE_RESTARTED;
		break;
		case ATH10K_STATE_ON:

Admin message