staging: unisys: visorbus change -1 return values (c294ea31) · Commits · 戴 / test

This patch changes the vague -1 return values to -EFAULT since it would be the most appropriate, given that this error would only occur in an unexpected bad offset field. Resulting in a bad address. Signed-off-by:

Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by:

David Kershner <david.kershner@unisys.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/unisys/visorbus/visorbus_main.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -876,10 +876,10 @@ write_vbus_chp_info(struct visorchannel *chan,
		int off = sizeof(struct channel_header) + hdr_info->chp_info_offset;

		if (hdr_info->chp_info_offset == 0)
		return -1;
		return -EFAULT;

		if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
		return -1;
		return -EFAULT;
		return 0;
		}

		@@ -895,10 +895,10 @@ write_vbus_bus_info(struct visorchannel *chan,
		int off = sizeof(struct channel_header) + hdr_info->bus_info_offset;

		if (hdr_info->bus_info_offset == 0)
		return -1;
		return -EFAULT;

		if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
		return -1;
		return -EFAULT;
		return 0;
		}

		@@ -915,10 +915,10 @@ write_vbus_dev_info(struct visorchannel *chan,
		(hdr_info->device_info_struct_bytes * devix);

		if (hdr_info->dev_info_offset == 0)
		return -1;
		return -EFAULT;

		if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
		return -1;
		return -EFAULT;
		return 0;
		}

Admin message