Commit c290f835 authored Oct 12, 2011 by Jiri Slaby Committed by Greg Kroah-Hartman Oct 18, 2011

TTY: drop driver reference in tty_open fail path



When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fdd (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: stable <stable@vger.kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 64d91cfa

drivers/tty/tty_io.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1873,6 +1873,7 @@ got_driver:
		if (IS_ERR(tty)) {
		tty_unlock();
		mutex_unlock(&tty_mutex);
		tty_driver_kref_put(driver);
		return PTR_ERR(tty);
		}
		}

Admin message