Commit c27f2fde authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: deprecate qual value 



This value is unused by mac80211, because it was only
be used by wireless extensions, and turned out to not
be useful there because the quality value needs to be
comparable between scan results and the current value
which is impossible when the qual value is calculated
taking into account noise, for example.

Since it is unused anyway, this patch deprecates it
in the hope that drivers will remove their sometimes
quite expensive calculations of the value.

I'm open to actual uses of the value, but the best
way of using it seems to be what the Intel drivers do
which should probably be generalised if we have noise
values from the hardware.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent eddcbb94

include/net/mac80211.h

+1 −1
Original line number Diff line number Diff line
@@ -552,7 +552,7 @@ struct ieee80211_rx_status { 
	int freq;

	int signal;

	int noise;

	int qual;

	int __deprecated qual;

	int antenna;

	int rate_idx;

	int flag;

net/mac80211/debugfs_sta.c

+0 −2
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ STA_FILE(tx_filtered, tx_filtered_count, LU); 
STA_FILE(tx_retry_failed, tx_retry_failed, LU);

STA_FILE(tx_retry_count, tx_retry_count, LU);

STA_FILE(last_signal, last_signal, D);

STA_FILE(last_qual, last_qual, D);

STA_FILE(last_noise, last_noise, D);

STA_FILE(wep_weak_iv_count, wep_weak_iv_count, LU);
@@ -205,7 +204,6 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta) 
	DEBUGFS_ADD(tx_retry_failed);

	DEBUGFS_ADD(tx_retry_count);

	DEBUGFS_ADD(last_signal);

	DEBUGFS_ADD(last_qual);

	DEBUGFS_ADD(last_noise);

	DEBUGFS_ADD(wep_weak_iv_count);

}

net/mac80211/rx.c

+0 −1
Original line number Diff line number Diff line
@@ -859,7 +859,6 @@ ieee80211_rx_h_sta_process(struct ieee80211_rx_data *rx) 
	sta->rx_fragments++;

	sta->rx_bytes += rx->skb->len;

	sta->last_signal = rx->status->signal;

	sta->last_qual = rx->status->qual;

	sta->last_noise = rx->status->noise;



	/*

net/mac80211/sta_info.h

+0 −2
Original line number Diff line number Diff line
@@ -193,7 +193,6 @@ struct sta_ampdu_mlme { 
 * @rx_fragments: number of received MPDUs

 * @rx_dropped: number of dropped MPDUs from this STA

 * @last_signal: signal of last received frame from this STA

 * @last_qual: qual of last received frame from this STA

 * @last_noise: noise of last received frame from this STA

 * @last_seq_ctrl: last received seq/frag number from this STA (per RX queue)

 * @tx_filtered_count: number of frames the hardware filtered for this STA
@@ -259,7 +258,6 @@ struct sta_info { 
	unsigned long rx_fragments;

	unsigned long rx_dropped;

	int last_signal;

	int last_qual;

	int last_noise;

	__le16 last_seq_ctrl[NUM_RX_DATA_QUEUES];

CRA Git | Maintained and supported by SUSTech CRA and CCSE