Commit c26736ec authored Jan 31, 2008 by Michael Chan Committed by David S. Miller Jan 31, 2008

[BNX2]: Fix ASYM PAUSE advertisement for remote PHY.



We were checking for the ASYM_PAUSE bit for 1000Base-X twice instead
checking for both the 1000Base-X bit and the 10/100/1000Base-T bit.
The purpose of the logic is to tell the firmware that ASYM_PAUSE is
set on either the Serdes or Copper interface.

Problem was discovered by Roel Kluin <12o3l@tiscali.nl>

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 29e75252

drivers/net/bnx2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1429,7 +1429,7 @@ bnx2_setup_remote_phy(struct bnx2 *bp, u8 port)

		if (pause_adv & (ADVERTISE_1000XPAUSE \| ADVERTISE_PAUSE_CAP))
		speed_arg \|= BNX2_NETLINK_SET_LINK_FC_SYM_PAUSE;
		if (pause_adv & (ADVERTISE_1000XPSE_ASYM \| ADVERTISE_1000XPSE_ASYM))
		if (pause_adv & (ADVERTISE_1000XPSE_ASYM \| ADVERTISE_PAUSE_ASYM))
		speed_arg \|= BNX2_NETLINK_SET_LINK_FC_ASYM_PAUSE;

		if (port == PORT_TP)

Admin message