Commit c25c853e authored Jul 03, 2020 by Baolin Wang Committed by Christoph Hellwig Jul 08, 2020

nvme-pci: remove redundant segment validation



We've validated the segment counts before calling nvme_map_data(),
so there is no need to validate again in nvme_pci_use_sgls(, which is
only called from nvme_map_data().

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 972b13e2

drivers/nvme/host/pci.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -501,9 +501,6 @@ static inline bool nvme_pci_use_sgls(struct nvme_dev dev, struct request req)
		int nseg = blk_rq_nr_phys_segments(req);
		unsigned int avg_seg_size;

		if (nseg == 0)
		return false;

		avg_seg_size = DIV_ROUND_UP(blk_rq_payload_bytes(req), nseg);

		if (!(dev->ctrl.sgls & ((1 << 0) \| (1 << 1))))

Admin message