Commit c23837ce authored Jun 25, 2015 by Grygorii Strashko Committed by Linus Walleij Jul 16, 2015

gpio: omap: prevent module from being unloaded while in use



OMAP GPIO driver allowed to be built as loadable module, but it
doesn't set owner field in GPIO chip structure. As result,
module_get/put() API is not working and it's possible to unload
OMAP driver while in use:

  omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED

Hence, add missing configuration.

Cc: Tony Lindgren <tony@atomide.com>
Fixes: cac089f9 ('gpio: omap: Allow building as a loadable module')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 34ab54ed

drivers/gpio/gpio-omap.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1187,6 +1187,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
		bank->irq = res->start;
		bank->dev = dev;
		bank->chip.dev = dev;
		bank->chip.owner = THIS_MODULE;
		bank->dbck_flag = pdata->dbck_flag;
		bank->stride = pdata->bank_stride;
		bank->width = pdata->bank_width;

Admin message