Commit c2371e80 authored Aug 26, 2013 by Marcel Holtmann Committed by Gustavo Padovan Sep 16, 2013

Bluetooth: Fix error handling for HCI socket options



The HCI sockets for monitor and control do not support any HCI specific
socket options and if tried, an error will be returned. However the
error used is EINVAL and that is not really descriptive. To make it
clear that these sockets are not handling HCI socket options, return
EBADFD instead.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

parent 808a049e

net/bluetooth/hci_sock.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -921,7 +921,7 @@ static int hci_sock_setsockopt(struct socket *sock, int level, int optname,
		lock_sock(sk);

		if (hci_pi(sk)->channel != HCI_CHANNEL_RAW) {
		err = -EINVAL;
		err = -EBADFD;
		goto done;
		}

		@@ -1007,7 +1007,7 @@ static int hci_sock_getsockopt(struct socket *sock, int level, int optname,
		lock_sock(sk);

		if (hci_pi(sk)->channel != HCI_CHANNEL_RAW) {
		err = -EINVAL;
		err = -EBADFD;
		goto done;
		}

Admin message