Commit c22eb937 authored May 05, 2020 by Hannes Reinecke Committed by Greg Kroah-Hartman May 13, 2020

sierra-ms: do not call scsi_get_host_dev()



scsi_get_host_dev() will create a virtual device such that either
the target id is ignored from scanning (if 'this_id' is set to
something which can be reached during scanning) or if the driver
needs a scsi device for the HBA to send commands to.
Neither is true for sierra-ms; 'this_id' remains at the default
value '-1' and the created device is never ever used within
the driver.
So kill it.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200505143019.57418-1-hare@suse.de


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2ca23ae5

drivers/usb/storage/sierra_ms.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -129,15 +129,11 @@ int sierra_ms_init(struct us_data *us)
		int result, retries;
		struct swoc_info *swocInfo;
		struct usb_device *udev;
		struct Scsi_Host *sh;

		retries = 3;
		result = 0;
		udev = us->pusb_dev;

		sh = us_to_host(us);
		scsi_get_host_dev(sh);

		/* Force Modem mode */
		if (swi_tru_install == TRU_FORCE_MODEM) {
		usb_stor_dbg(us, "SWIMS: Forcing Modem Mode\n");

Admin message