Commit c227e690 authored Sep 22, 2010 by Arnd Bergmann Committed by Linus Torvalds Sep 22, 2010

/proc/vmcore: fix seeking



Commit 73296bc6 ("procfs: Use generic_file_llseek in /proc/vmcore")
broke seeking on /proc/vmcore.  This changes it back to use default_llseek
in order to restore the original behaviour.

The problem with generic_file_llseek is that it only allows seeks up to
inode->i_sb->s_maxbytes, which is zero on procfs and some other virtual
file systems.  We should merge generic_file_llseek and default_llseek some
day and clean this up in a proper way, but for 2.6.35/36, reverting vmcore
is the safer solution.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Reported-by: CAI Qian <caiqian@redhat.com>
Tested-by: CAI Qian <caiqian@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a9e31765

fs/proc/vmcore.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ static ssize_t read_vmcore(struct file file, char __user buffer,

		static const struct file_operations proc_vmcore_operations = {
		.read = read_vmcore,
		.llseek = generic_file_llseek,
		.llseek = default_llseek,
		};

		static struct vmcore* __init get_new_element(void)

Admin message