mfd: twl6030: Cleanup interrupt handling (c22435a3) · Commits · 戴 / test

irq_desc checking in the interrupt demux routine is totally pointless. The driver sets those lines up, so that cant go away magically. Remove the open coded handler magic and use the proper accessor. This driver needs to be converted to threaded interrupts and buslock. Signed-off-by:

Thomas Gleixner <tglx@linutronix.de> Signed-off-by:

Samuel Ortiz <sameo@linux.intel.com>

drivers/mfd/twl6030-irq.c

+1 −16

Original line number	Diff line number	Diff line
		@@ -140,22 +140,7 @@ static int twl6030_irq_thread(void *data)
		if (sts.int_sts & 0x1) {
		int module_irq = twl6030_irq_base +
		twl6030_interrupt_mapping[i];
		struct irq_desc *d = irq_to_desc(module_irq);

		if (!d) {
		pr_err("twl6030: Invalid SIH IRQ: %d\n",
		module_irq);
		return -EINVAL;
		}

		/* These can't be masked ... always warn
		* if we get any surprises.
		*/
		if (d->status & IRQ_DISABLED)
		note_interrupt(module_irq, d,
		IRQ_NONE);
		else
		d->handle_irq(module_irq, d);
		generic_handle_irq(module_irq);

		}
		local_irq_enable();

Admin message