ALSA: riptide: convert tasklets to use new tasklet_setup() API (c2082393) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Link: https://lore.kernel.org/r/20200902040221.354941-5-allen.lkml@gmail.com Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/pci/riptide/riptide.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1070,9 +1070,9 @@ getmixer(struct cmdif cif, short num, unsigned short rval,
		return 0;
		}

		static void riptide_handleirq(unsigned long dev_id)
		static void riptide_handleirq(struct tasklet_struct *t)
		{
		struct snd_riptide chip = (void )dev_id;
		struct snd_riptide *chip = from_tasklet(chip, t, riptide_tq);
		struct cmdif *cif = chip->cif;
		struct snd_pcm_substream *substream[PLAYBACK_SUBSTREAMS + 1];
		struct snd_pcm_runtime *runtime;
		@@ -1843,7 +1843,7 @@ snd_riptide_create(struct snd_card card, struct pci_dev pci,
		chip->received_irqs = 0;
		chip->handled_irqs = 0;
		chip->cif = NULL;
		tasklet_init(&chip->riptide_tq, riptide_handleirq, (unsigned long)chip);
		tasklet_setup(&chip->riptide_tq, riptide_handleirq);

		if ((chip->res_port =
		request_region(chip->port, 64, "RIPTIDE")) == NULL) {

Admin message